EVA-1190 Report studies browsable since given date#89
Open
cyenyxe wants to merge 2 commits intoEBIvariation:masterfrom
Open
EVA-1190 Report studies browsable since given date#89cyenyxe wants to merge 2 commits intoEBIvariation:masterfrom
cyenyxe wants to merge 2 commits intoEBIvariation:masterfrom
Conversation
jmmut
suggested changes
May 1, 2018
|
|
||
| List<VariantStudySummary> results = queryResponse.getResponse().get(0).getResult(); | ||
| assertTrue(results.size() >= 1); | ||
| System.out.println(results); |
pabarcgar
reviewed
May 1, 2018
Contributor
pabarcgar
left a comment
pabarcgar
left a comment
There was a problem hiding this comment.
Approved changes, but subjected to possible change of naming
andresfsilva
approved these changes
May 1, 2018
jmmut
suggested changes
May 2, 2018
| assertEquals(1, queryResponse.getResponse().size()); | ||
|
|
||
| List<VariantStudySummary> results = queryResponse.getResponse().get(0).getResult(); | ||
| assertEquals(0, results.size()); |
Contributor
There was a problem hiding this comment.
this test failed in travis https://travis-ci.org/EBIvariation/eva-ws/builds/373408145#L4349
sundarvenkata-EBI
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional date parameter to endpoint.