Draft
Conversation
untitaker
force-pushed
the
orbic-network-connection-pooling
branch
from
e531aff to
a63078e
Compare
Every once in a while, I get the error posted in #901: Caused by: 0: Failed to send login request 1: error sending request 2: client error (SendRequest) 3: connection closed before message completed (either this or "failed to start telnet" -- in either case there's a request happening before it, and it's always "connection closed before message completed") Disabling connection pooling seems to reduce the amount of flakiness. Here is what I used to test this fix: while echo | cargo run -p installer util orbic-shell --admin-password 96df5476 ; do true; done Usually it would stop <100 iterations, now it can do 800+ iterations.
untitaker
force-pushed
the
orbic-network-connection-pooling
branch
from
a63078e to
1e2c81d
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every once in a while, I get the error posted in #901:
Either "failed to send login request" or "failed to start telnet" -- in either case there's a
request happening before it, and it's always "connection closed before
message completed".
This is on firmware version
ORB400L_V1.1.5_BVZRT, stock orbic.Disabling connection pooling seems to reduce the amount of flakiness.
Here is what I used to test this fix:
Usually it would stop <100 iterations, now it can do 800+ iterations.