Skip to content

user role list fix #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyanka-TL wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

user role list fix #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/services/user-role.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ module.exports = class userRoleHelper {

static async list(filters, page, limit, search, userOrganizationId) {
try {
let result = {
data: [],
count: 0,
}
delete filters.search
const offset = common.getPaginationOffset(page, limit)
const options = {
Expand All @@ -152,22 +156,21 @@ module.exports = class userRoleHelper {
const attributes = ['id', 'title', 'user_type', 'visibility', 'status', 'organization_id']
const roles = await roleQueries.findAllRoles(filter, attributes, options)

if (roles.rows == 0 || roles.count == 0) {
return responses.failureResponse({
message: 'ROLES_HAS_EMPTY_LIST',
statusCode: httpStatusCode.bad_request,
responseCode: 'CLIENT_ERROR',
if (!roles.rows.length > 0 || roles.count == 0) {
return responses.successResponse({
statusCode: httpStatusCode.ok,
message: 'ROLES_FETCHED_SUCCESSFULLY',
result,
})
}
const results = {
data: roles.rows,
count: roles.count,
}

result.data = roles.rows
result.count = roles.count

return responses.successResponse({
statusCode: httpStatusCode.ok,
message: 'ROLES_FETCHED_SUCCESSFULLY',
result: results,
result,
})
} catch (error) {
throw error
Expand Down