Skip to content

Conversation

@jimmielin
Copy link
Member

@jimmielin jimmielin commented Oct 23, 2025

Tag name (required for release branches):
Originator(s): @jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • Try to add cnst_ and pbuf_ (prescribed fields from CAM) when reading input files for constituents when they are not in the registry; this is to avoid unnecessary entries in the registry for constituents if the sole purpose is to specify ic_file_input_names for them;
  • When reading constituent-dimensioned input fields (e.g., cam_in_cflx_<name>) from snapshot, try to use the name without the cnst_ prefix that SIMA adds, e.g., cam_in_cflx_num_a4 instead of just cam_in_cflx_cnst_num_a4 right now.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       src/data/write_init_files.py
M       test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_param.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90
M       test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90
  - try cnst_ and pbuf_ prefix for constituent read

M       src/physics/utils/physics_data.F90 
  - try removing cnst_ for constituent-dimensioned input fields

M       src/data/registry.xml
  - the above changes allow us to remove "trivial" constituent input name entries
    from the registry.xml file.

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin jimmielin self-assigned this Oct 23, 2025
@jimmielin jimmielin added the enhancement New feature or request label Oct 23, 2025
@jimmielin jimmielin changed the title Use cnst_ and pbuf_ alternative ic names when reading constituents not in the registry Use cnst_ and pbuf_ alternative ic names when reading constituents not in the registry; try no cnst_ names for constituent-dimensioned input fields Nov 24, 2025
@jimmielin jimmielin marked this pull request as ready for review November 24, 2025 16:54
@jimmielin
Copy link
Member Author

fcdba17 is a cherry-pick from ongoing work in UW PBL

@jimmielin
Copy link
Member Author

Once #439 is merged we could try using this PR and then removing the extra entries in registry.xml could be possible

    <variable local_name="CH4"
	      standard_name="CH4"
	      units="kg kg-1" type="real" constituent="true">
      <ic_file_input_names>CH4 cnst_CH4</ic_file_input_names>
    </variable>
    <variable local_name="CFC12"
	      standard_name="CFC12"
	      units="kg kg-1" type="real" constituent="true">
      <ic_file_input_names>CFC12 cnst_CFC12</ic_file_input_names>
    </variable>
    <variable local_name="CFC11"
	      standard_name="CFC11"
	      units="kg kg-1" type="real" constituent="true">
      <ic_file_input_names>CFC11STAR pbuf_CFC11STAR</ic_file_input_names>
    </variable>

if it works we could remove the new entries from #439 in this PR as well when this is merged (and passes all the tests)

@jimmielin jimmielin requested a review from peverwhee January 6, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant