Refactor vertical coordinate computation in MPAS dynamical core #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
sima0_10_001 (Tentative)
Originator(s):
kuanchihwang
Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
MPAS dynamical core uses height, denoted by$\zeta$ , as the vertical coordinate system. In CAM-SIMA, the coordinate values are computed in the interface layer of MPAS dynamical core for history and physics initialization.
However, it can be argued that the vertical coordinate system should be considered an implementation detail of MPAS dynamical core, and that it should not concern CAM-SIMA. See Appendix "C.2 Vertical grid" in MPAS user guide for more information.
This PR refactors and relocates vertical coordinate computation to the subdriver layer of MPAS dynamical core. Now, CAM-SIMA just calls the appropriate procedures to get the coordinate values. Unit tests are added to ensure correctness.
This PR also ports a fix from CAM (ESCOMP/CAM#1095) to limit longitude values within the range of$[0, 2 \pi)$ according to MPAS mesh specifications.
Describe any changes made to the build system:
None
Describe any changes made to the namelist:
None
List any changes to the defaults for the input datasets (e.g., boundary datasets):
None
List all files eliminated and why:
None
List all files added and what they do:
None
List all existing files that have been modified, and describe the changes:
Regression tests:
Round-off errors due to limiting longitude values within the range of$[0, 2 \pi)$ .
Known failing test.