Skip to content

Conversation

@peverwhee
Copy link
Collaborator

Tag name (required for release branches):
Originator(s): peverwhee

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Bugfix for dimensions that are defined in the registry and then used to allocate a different registry variable.

Describe any changes made to build system:

M    src/data/generate_registry_data.py
- use the local name for allocating dimensions defined in the registry (but use standard name for metadata)

Describe any changes made to the namelist: n/a

List any changes to the defaults for the input datasets (e.g. boundary datasets): n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M  test/unit/python/sample_files/physics_types_complete.F90
M  test/unit/python/sample_files/physics_types_complete.meta
M  test/unit/python/sample_files/reg_good_complete.xml
- use local registry dimension in full registry test

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: all b4b

derecho/gnu/aux_sima: all b4b

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@peverwhee peverwhee requested a review from nusbaume January 13, 2026 23:29
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

@nusbaume nusbaume requested a review from jimmielin January 14, 2026 13:41
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants