Bring in acc directives to enable GPU runs in SIMA #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull ZM 0.5 timestep removal into main
Replace original, locally-developed license with Apache 2.0 license.
Bring in development ESCOMP#108 (TUV-x) ESCOMP#112 (tropopause_find) to main
Bring in new directory structure from development
Upgrading to atmos_phys0_06_000
Tag name (The PR title should also include the tag name): `atmos_phys0_07_000` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * ESCOMP#141 by @mattldawson @boulderdaze * ESCOMP#147 by @peverwhee * ESCOMP#144 by @mwaxmonsky * ESCOMP#151 by @mattldawson * ESCOMP#145 by @jimmielin List all test failures: N/A
Tag name (The PR title should also include the tag name): `atmos_phys0_07_001` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * Update extraterrestrial flux in TUV-x prior to calculating rate constants ESCOMP#152 by @boulderdaze * Simplify deallocation of multiple objects associated with the TUV-x ESCOMP#156 by @boulderdaze * Fill in errmsg, errflg in check_energy schemes ESCOMP#160 by @jimmielin * Validates the MUSICA meta data against the CCPP standard names ESCOMP#162 by @boulderdaze * Add constituent tendency updater ESCOMP#111 by @peverwhee * Add cloud optical calculations for use in TUV-x ESCOMP#167 by @mattldawson * Add initialize_constituents scheme ESCOMP#149 by @peverwhee * Add diagnostics to TJ2016 test schemes ESCOMP#170 by @peverwhee * update "radians" to "rad" ESCOMP#173 by @peverwhee * Solar zenith angle and Earth-Sun distance ESCOMP#171 by @mattldawson * Update standard names for tropopause_find ESCOMP#140 by @jimmielin * Update surface albedo units ESCOMP#181 by @mattldawson * don't set water species property for species that air_composition handles ESCOMP#185 by @peverwhee List all test failures: N/A
Tag: atmos_phys0_08_000 Use new constituent tendency updater in cam7 SDF ESCOMP#188 MUSICA TUVX scheme: create aerosol radiator, set_aerosol_optics_values ESCOMP#182 Set gas-species profiles in TUV-x and map indices between constituents and MICM ESCOMP#184 Complete Zhang McFarlane conversion to CCPP ESCOMP#186
Brings in new PR templates for atmospheric_physics - as there's no easy way to have multiple accessible PR templates in GitHub, this includes a default template that contains links to the PR templates
Tag name (The PR title should also include the tag name): atmos_phys0_09_000 Originator(s): @mwaxmonsky List all `development` PR numbers included in this PR and the title of each: * Add diagnostic output for ALL constituents ESCOMP#199 by @peverwhee * Build MUSICA in CAM-SIMA ESCOMP#198 by @boulderdaze * Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update) ESCOMP#178 by @jimmielin and @nusbaume * Implement diagnostics for global energy fixer, check_energy standard name update ESCOMP#169 by @jimmielin * Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test ESCOMP#204 by @jimmielin * PBL utils transfer ESCOMP#193 by @mwaxmonsky and @nusbaume List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Tag name (The PR title should also include the tag name): atmos_phys0_10_000 Originator(s): @jimmielin List all `development` PR numbers included in this PR and the title of each: * CCPPize Hack shallow convection ESCOMP#195 by @jimmielin * Update MUSICA index mapping API and CMake script ESCOMP#208 by @boulderdaze List all automated tests that failed, as well as an explanation for why they weren't fixed: * B4B for CAM * New baselines in CAM7/CAM4 in CAM-SIMA
Tag name (The PR title should also include the tag name): atmos_phys0_10_001 Originator(s): @nusbaume List all development PR numbers included in this PR and the title of each: * ESCOMP#214 by @swrneale List all automated tests that failed, as well as an explanation for why they weren't fixed: New NLCOMP results in CAM New NLCOMP results in CAM-SIMA
Tag name (The PR title should also include the tag name): Originator(s): List all `development` PR numbers included in this PR and the title of each: - update instantaneous history flag to be 'inst' instead of 'lst' (ESCOMP#218) - CCPPize dme_adjust (ESCOMP#211) - Fix broken github action tests (ESCOMP#228) List all automated tests that failed, as well as an explanation for why they weren't fixed: none --------- Co-authored-by: Courtney Peverley <courtneyp@ucar.edu>
Tag name (The PR title should also include the tag name): atmos_phys0_12_000 Originator(s): @jimmielin List all `development` PR numbers included in this PR and the title of each: - ESCOMP#229 by @peverwhee - ESCOMP#219 by @jimmielin List all automated tests that failed, as well as an explanation for why they weren't fixed: None
Tag name (The PR title should also include the tag name): atmos_phys0_13_000 Originator(s): @Katetc, @nusbaume List all development PR numbers included in this PR and the title of each: PR ESCOMP#200 - Rayleigh Friction CCPP List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A (All tests passed)
…ospheric_physics into rrtmgp-diagnostics
nusbaume
reviewed
Jan 13, 2026
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @peverwhee! I had one question about a directive, and a request to update the PR description, but otherwise this PR looks good to me!
| [ current_cal_day ] | ||
| standard_name = fractional_calendar_days_on_end_of_current_timestep | ||
| units = 1 | ||
| units = days |
Collaborator
There was a problem hiding this comment.
Can you add this file to the list in the PR description so that it gets included in the Git log? I have this same request for the other files not listed in the PR description as well. Thanks!
Collaborator
Author
There was a problem hiding this comment.
good call - added
| iCol = ((iter_num - 1) * rrtmgp_phys_blksz) + 1 | ||
| iCol2= min(iCol + rrtmgp_phys_blksz - 1, ncol) | ||
|
|
||
| !$acc data copyin(sw_gas_props%gas_props,p_lay,p_lev,t_lay,gas_concs%gas_concs,sw_optical_props%optical_props) & |
Collaborator
There was a problem hiding this comment.
Shouldn't sw_optical_props%optical_props be in a copy or copyout call? Otherwise I am not sure how that works with an intent(out) variable.
Collaborator
Author
There was a problem hiding this comment.
a good point! I've moved it to "copy" and am running the nvhpc test in CAM to see if it still works. Not sure how this worked before and in SIMA!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): peverwhee
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
addresses #154
closes #325
List all namelist files that were added or changed: n/a
List all files eliminated and why: n/a
List all files added and what they do: n/a
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? no
If yes to the above question, describe how this code was validated with the new/modified features: