-
Notifications
You must be signed in to change notification settings - Fork 32
Update CAM4 physics suite for SIMA aquaplanet configurations #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tag name (The PR title should also include the tag name): atmos_phys0_13_000 Originator(s): @Katetc, @nusbaume List all development PR numbers included in this PR and the title of each: PR ESCOMP#200 - Rayleigh Friction CCPP List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A (All tests passed)
…mature test failure.
jimmielin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume! I had a few questions but nothing major. Excited to see QPC4 come true 🥳
jimmielin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume!
peverwhee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny comment but looks good to me!
Originator(s): nusbaume
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
Add namelist modifications and additional helper schemes in order to run the full CAM4 physics suite in CAM-SIMA in aquaplanet mode.
List all namelist files that were added or changed:
A schemes/radiation_utils/radiative_gas_concentrations_namelist.xml
M schemes/cloud_fraction/compute_cloud_fraction_namelist.xml
M schemes/gravity_wave_drag/gw_common_namelist.xml
M schemes/radiation_utils/solar_irradiance_data_namelist.xml
M schemes/rrtmgp/rrtmgp_constituents_namelist.xml
M schemes/zhang_mcfarlane/zm_conv_options_namelist.xml
List all files eliminated and why: N/A
List all files added and what they do:
A schemes/radiation_utils/radiative_gas_concentrations.F90
A schemes/radiation_utils/radiative_gas_concentrations.meta
A schemes/utilities/set_surface_coupling_vars.F90
A schemes/utilities/set_surface_coupling_vars.meta
cam_out) coupler variables.List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M schemes/rasch_kristjansson/prognostic_cloud_water.F90
M suites/suite_cam4.xml
M suites/suite_cam7.xml
List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes, at least for full physics CAM4 aquaplanet simulations. This PR introduces new schemes and namelist values to the CAM4 physics suite, which is what allows this configuration to run in CAM-SIMA.
If yes to the above question, describe how this code was validated with the new/modified features:
Performed a short, three month run and examined the model output, at least for some generic state variables (U,V,T,Q,PS). All of the results seemed reasonable, and the model successfully ran to completion.