-
Notifications
You must be signed in to change notification settings - Fork 32
PUMAS round3 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cacraigucar
wants to merge
26
commits into
ESCOMP:main
Choose a base branch
from
nusbaume:pumas_round3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PUMAS round3 #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns_pre' init phase.
atmos_phys0_20_000: Merge development to main (ESCOMP#345)
…mment to top for reviewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): cacraigucar, nusbaume, billsacks, peverwhee, I-Kuan Hu
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
List all namelist files that were added or changed:
A schemes/pumas/pumas_pre_main_namelist.xml
- pumas CAM-SIMA namelist generator
List all files eliminated and why: N/A
List all files added and what they do:
A schemes/pumas/micro_pumas_ccpp_dimensions_post.F90
A schemes/pumas/micro_pumas_ccpp_dimensions_post.meta
A schemes/pumas/micro_pumas_ccpp_dimensions_pre.F90
A schemes/pumas/micro_pumas_ccpp_dimensions_pre.meta
- code which subsets and converts to pumas_r8 and back
A schemes/pumas/pumas_pre_main.F90
A schemes/pumas/pumas_pre_main.meta
- placeholder for interstitial schemes
A schemes/sima_diagnostics/pumas_diagnostics.F90
A schemes/sima_diagnostics/pumas_diagnostics_calling.F90
- These are being included even though they are only partially complete - NO REVIEW IS BEING DONE NOW
A test/test_suites/suite_pumas.xml
- test suite for PUMAS
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M .gitmodules
M doc/NamesNotInDictionary.txt
M schemes/pumas/pumas
List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
- new capability in CAM-SIMA
If yes to the above question, describe how this code was validated with the new/modified features: