Set Cache-Control header on asset download redirect

[DTTerastar]

Summary by CodeRabbit

• Chores
  • Optimized download redirect caching by implementing HTTP cache headers to improve performance and reduce unnecessary network requests.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change adds explicit Cache-Control headers to redirect responses in the latest-any/download flow, setting the redirect to cache for 3600 seconds (1 hour) via the max-age directive. The redirect logic remains functionally unchanged.

Changes

Cohort / File(s)	Summary
Cache header on redirect response espresense-release-proxy/src/index.ts	Introduces intermediate redirectResponse variable in download flow to explicitly set Cache-Control: public, max-age=3600 header on redirect response before returning

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a redirect, swift as can be,
Now cached for an hour—efficiency!
No need to fetch thrice what we've seen before,
The rabbit approves, let the cache soar! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: setting Cache-Control headers on asset download redirects in the latest-any/download flow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cache-redirect

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 837f07e and dffdf76.

📒 Files selected for processing (1)

• espresense-release-proxy/src/index.ts

🔇 Additional comments (1)

espresense-release-proxy/src/index.ts (1)

164-167: The implementation correctly handles caching for redirect responses.

The Cache-Control header must be set manually on the redirect response because Hono's cache middleware (line 137) is configured to cache only status code 200 by default. Without the cacheableStatusCodes option including 302, the middleware doesn't cache redirect responses, making the manual header necessary to instruct Cloudflare's edge cache to cache this redirect for 1 hour.

Note: The cache middleware on line 137 will cache the JSON error responses (200 status), which may or may not be desired—consider reviewing whether those responses should be cached.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}