[ENH]: Change uid and gid permissions on bucket creation#29
Open
[ENH]: Change uid and gid permissions on bucket creation#29
Conversation
Contributor
|
When I try to select start jupyterlab at the end of The bucket status is listed as However, if I try to start the bucket, I get an error that the bucket is already running. I didn't have any of these issues when I was testing PR #27 . |
…nh_change_uid_gid_permissions
pmreyes2
requested changes
Jun 11, 2019
Contributor
There was a problem hiding this comment.
ERROR: Bucket test3 is not running!
happens because the container has been started insideDockerHelper.create_containerand the following is missing:
self.buckets[ind]['docker']['status'] = 'running'
self.save_config()
- The
/usr/local/bin/start.shshould be executed withdetach=Falsefor thechowns to finish before starting jupyter. If the jupyter notebook is started before this process, the notebook with the token doesn't work. - A suggestion would be to put the execution of
/usr/local/bin/start.shinsideDockerHelper.start_container. I have tested that and it works. Its in the branch: fix_uid_gid. I could to a PR to merge that into enh_guided_create_bucket - Unfortunately it takes long to chown all the files both in linux and mac. But in mac is not needed. If we find a way to know what systems need this fix. Maybe something like
docker0.info()['OSType'] == 'linux'. But I don't know if all linux systems need this.
Contributor
Author
|
Not touching this until after 2019.1.0rc2 is out. Low priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #13, on some systems, the UID and GID of user directories on the host are not the same as the default in the resen-core image. This PR executes
/usr/local/bin/start.shwith theNB_UIDandNB_GIDenvironment variables set.The side effect of doing this is that it takes a little while for all of the files in
/home/jovyanto change permissions, but this will get better once EarthCubeInGeo/resen-core#19 is implemented.To test this, just create a new bucket. Then in jupyterlab, open terminal and execute the
topcommand. You will probably see achmodcommand running, unless you happen to have the same uid and gid as is default for the jovyan user in the container.Please merged PR #27 before merging this one.