Skip to content

Beta #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luc1412 merged 9 commits into from
Oct 21, 2025
Merged

Beta #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5cd1071
Fix image resizing
Luc1412 Oct 20, 2025
ce12c48
skip skia v3
NotOfficer Oct 21, 2025
da6a6d0
optimizations & fixed memory leaks
NotOfficer Oct 21, 2025
2c580d9
missing argument
NotOfficer Oct 21, 2025
8a56665
Merge pull request #115
Luc1412 Oct 21, 2025
8dfb30f
Replace missing console writes with logging
Luc1412 Oct 21, 2025
5354570
format and optimize code
Luc1412 Oct 21, 2025
5be2428
Rework shop image caching and regenrate behaviour. Instead if using n…
Luc1412 Oct 21, 2025
c65191a
Merge pull request #116 from EasyFortniteStats/main
Luc1412 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 67 additions & 46 deletions Controllers/LockerImageController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,28 @@ public class AccountImageController(
};

[HttpPost]
public async Task<IActionResult> Post(Locker locker, [FromQuery] bool? lossless)
public async Task<IActionResult> Post(Locker locker, [FromQuery] bool? lossless, CancellationToken cancellationToken)
{
logger.LogInformation(
"Locker image request received | Name = {PlayerName} | Locale = {Locale} | Items = {Items}",
locker.PlayerName, locker.Locale, locker.Items.Length);
var lockKey = $"locker_{locker.RequestId}";
using (await namedLock.LockAsync(lockKey).ConfigureAwait(false))

using (await namedLock.LockAsync($"locker_{locker.RequestId}", cancellationToken).ConfigureAwait(false))
{
await GenerateItemCards(locker);
await GenerateItemCards(locker, cancellationToken);
}

using var lockerBitmap = await GenerateImage(locker);

// Determine the quality of the image based on quality mapping and locker.Items.Length
var quality = lossless == true ? 100 : QualityMapping.FirstOrDefault(x => locker.Items.Length <= x.Count).Quality;
return File(lockerBitmap.Encode(SKEncodedImageFormat.Jpeg, quality).AsStream(true), "image/jpeg");
using (locker)
{
using var lockerBitmap = await GenerateImage(locker);

// Determine the quality of the image based on quality mapping and locker.Items.Length
var quality = lossless == true
? 100
: QualityMapping.FirstOrDefault(x => locker.Items.Length <= x.Count).Quality;
var data = lockerBitmap.Encode(SKEncodedImageFormat.Jpeg, quality);
return File(data.AsStream(true), "image/jpeg");
}
}

private async Task<SKBitmap> GenerateImage(Locker locker)
Expand All @@ -70,7 +76,7 @@ private async Task<SKBitmap> GenerateImage(Locker locker)
var bitmap = new SKBitmap(imageInfo);
using var canvas = new SKCanvas(bitmap);

using var backgroundPaint = new SKPaint();
using var backgroundPaint = new SKPaintSafe();
backgroundPaint.IsAntialias = true;
backgroundPaint.Shader = SKShader.CreateLinearGradient(
new SKPoint((float)imageInfo.Width / 2, 0),
Expand All @@ -84,18 +90,20 @@ private async Task<SKBitmap> GenerateImage(Locker locker)
var textBounds = new SKRect();
var segoeFont = await assets.GetFont("Assets/Fonts/Segoe.ttf"); // don't dispose

var icon = await assets.GetBitmap("Assets/Images/Locker/Icon.png"); // don't dispose
var iconBitmap = await assets.GetBitmap("Assets/Images/Locker/Icon.png"); // don't dispose
var resize = (int)(50 * uiResizingFactor);
using var resizeIcon = icon!.Resize(new SKImageInfo(resize, resize), SKFilterQuality.High);
canvas.DrawBitmap(resizeIcon, 50, 50);
using var drawIconPaint = new SKPaint();
drawIconPaint.IsAntialias = true;
drawIconPaint.FilterQuality = SKFilterQuality.High;
canvas.DrawBitmap(iconBitmap, SKRect.Create(50, 50, resize, resize), drawIconPaint);

using var splitPaint = new SKPaint();
splitPaint.IsAntialias = true;
splitPaint.Color = SKColors.White;

var splitWidth = 5 * uiResizingFactor;
var splitR = 3 * uiResizingFactor;
canvas.DrawRoundRect(50 + resizeIcon.Width + splitWidth, 57, splitWidth, 50 * uiResizingFactor, splitR, splitR,
canvas.DrawRoundRect(50 + resize + splitWidth, 57, splitWidth, 50 * uiResizingFactor, splitR, splitR,
splitPaint);

using var namePaint = new SKPaint();
Expand All @@ -106,7 +114,7 @@ private async Task<SKBitmap> GenerateImage(Locker locker)
namePaint.FilterQuality = SKFilterQuality.Medium;

namePaint.MeasureText(locker.PlayerName, ref textBounds);
canvas.DrawText(locker.PlayerName, 50 + resizeIcon.Width + splitWidth * 3, 58 - textBounds.Top, namePaint);
canvas.DrawText(locker.PlayerName, 50 + resize + splitWidth * 3, 58 - textBounds.Top, namePaint);

using var discordBoxBitmap = await ImageUtils.GenerateDiscordBox(assets, locker.UserName, uiResizingFactor);
canvas.DrawBitmap(discordBoxBitmap, imageInfo.Width - 50 - discordBoxBitmap.Width, 39);
Expand All @@ -119,7 +127,6 @@ private async Task<SKBitmap> GenerateImage(Locker locker)
item.Image,
50 + 256 * column + 25 * column,
50 + nameFontSize + 50 + row * 313 + row * 25);
item.Image?.Dispose();
column++;
if (column != columns) continue;
column = 0;
Expand All @@ -134,20 +141,26 @@ private async Task<SKBitmap> GenerateImage(Locker locker)
return bitmap;
}

private async Task GenerateItemCards(Locker locker)
private async Task GenerateItemCards(Locker locker, CancellationToken cancellationToken)
{
var options = new ParallelOptions
{
MaxDegreeOfParallelism = Environment.ProcessorCount / 2
MaxDegreeOfParallelism = Environment.ProcessorCount / 2,
CancellationToken = cancellationToken
};
using var client = clientFactory.CreateClient();
await Parallel.ForEachAsync(locker.Items, options, async (item, token) =>
{
var filePath = Path.Combine(BASE_ITEM_IMAGE_PATH, $"{item.Id}.png");
SKBitmap? itemImage = null;
if (!System.IO.File.Exists(filePath) && item.ImageUrl is not null)
var fileExists = System.IO.File.Exists(filePath);

byte[]? itemImageBytes = null;
if (fileExists)
{
itemImageBytes = await System.IO.File.ReadAllBytesAsync(filePath, token);
}
else if (item.ImageUrl is not null)
{
using var client = clientFactory.CreateClient();
byte[]? itemImageBytes;
try
{
var imageUrl = changeUrlImageSize(item.ImageUrl, 256);
Expand All @@ -162,45 +175,51 @@ await Parallel.ForEachAsync(locker.Items, options, async (item, token) =>
catch (HttpRequestException e2)
{
logger.LogWarning(
"Failed to download image with status {StatusCode} for {Name} ({ImageUrl}) ",
"Failed to download image with status {HttpStatusCode} for {ItemName} ({ItemImageUrl}) ",
e2.StatusCode, item.Name, item.ImageUrl);
itemImageBytes = null;
}
}
catch (HttpRequestException e)
{
logger.LogWarning(
"Failed to download image with status {StatusCode} for {Name} ({ImageUrl}) ",
"Failed to download image with status {HttpStatusCode} for {ItemName} ({ItemImageUrl}) ",
e.StatusCode, item.Name, item.ImageUrl);
itemImageBytes = null;
}
}

SKBitmap? itemImage = null;

if (itemImageBytes is not null)
if (itemImageBytes is not null)
{
var itemImageRaw = SKBitmap.Decode(itemImageBytes);
if (itemImageRaw.Width != 256 || itemImageRaw.Height != 256)
{
var itemImageRaw = SKBitmap.Decode(itemImageBytes);
if (itemImageRaw.Width != 256 || itemImageRaw.Height != 256)
{
itemImage = itemImageRaw.Resize(new SKImageInfo(256, 256), SKFilterQuality.Medium);
}
else
{
itemImage = itemImageRaw;
}
fileExists = false;
var resized = itemImageRaw.Resize(new SKImageInfo(256, 256), SKFilterQuality.Medium);
itemImageRaw.Dispose();
itemImage = resized;
}
else
{
itemImage = itemImageRaw;
}

if (!fileExists)
{
Directory.CreateDirectory(BASE_ITEM_IMAGE_PATH);
using var data = itemImage.Encode(SKEncodedImageFormat.Png, 100);
var dataBytes = data.AsSpan().ToArray();
await using var fileStream = new FileStream(filePath, FileMode.Create, FileAccess.Write,
FileShare.None, 4096, true);
using var data = itemImage.Encode(SKEncodedImageFormat.Png, 100);
data.SaveTo(fileStream);
fileStream.SetLength(dataBytes.LongLength);
await fileStream.WriteAsync(dataBytes, token);
}
}
else if (System.IO.File.Exists(filePath))

using (itemImage)
{
itemImage = SKBitmap.Decode(filePath);
item.Image = await GenerateItemCard(item, itemImage);
}

item.Image = await GenerateItemCard(item, itemImage);
itemImage?.Dispose();
});
}

Expand Down Expand Up @@ -309,9 +328,11 @@ private async Task<SKBitmap> GenerateFooter(float resizeFactor)
using var canvas = new SKCanvas(bitmap);

var logoBitmap = await assets.GetBitmap("Assets/Images/Logo.png"); // don't dispose
var logoBitmapResize =
logoBitmap!.Resize(new SKImageInfo(imageInfo.Height, imageInfo.Height), SKFilterQuality.High);
canvas.DrawBitmap(logoBitmapResize, new SKPoint(0, 0));

using var drawLogoPaint = new SKPaint();
drawLogoPaint.IsAntialias = true;
drawLogoPaint.FilterQuality = SKFilterQuality.High;
canvas.DrawBitmap(logoBitmap, SKRect.Create(0, 0, imageInfo.Height, imageInfo.Height), drawLogoPaint);

var splitR = 3 * resizeFactor;

Expand Down
Loading