-
Notifications
You must be signed in to change notification settings - Fork 82
remove net6.0 and update tests to net10.0 #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Imo, the condition
made |
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net6.0;net8.0</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;net10.0;net8.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <TargetFrameworks>netstandard2.0;net10.0;net8.0</TargetFrameworks> | |
| <TargetFrameworks>netstandard2.0;net8.0;net10.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But honestly I don't think that new tfm is needed. Are there any new apis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, just removed net6.0 target since it's out of support
I think it's for .NET 6 target since the project targets for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the test projects to .NET 10, removes .NET 6.0 support from the main library, and modernizes the solution structure by migrating to the .slnx format. The changes also remove obsolete JSON serialization code that's no longer needed with the updated framework targets.
- Removed .NET 6.0 target framework from the main library project (now targets netstandard2.0 and net8.0)
- Updated all test projects from net8.0 to net10.0
- Replaced legacy .sln file with modern .slnx format and updated all CI workflow references
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Source/EasyNetQ.Management.Client/EasyNetQ.Management.Client.csproj | Removed net6.0 from target frameworks, keeping netstandard2.0 and net8.0 for library compatibility |
| Source/EasyNetQ.Management.Client/Serialization/JsonNumberEnumConverter.cs | Removed custom enum converter no longer needed after dropping net6.0 support |
| Source/EasyNetQ.Management.Client.Tests/EasyNetQ.Management.Client.Tests.csproj | Updated test framework from net8.0 to net10.0; made System.Text.Json conditional for net48 only |
| Source/EasyNetQ.Management.Client.IntegrationTests/EasyNetQ.Management.Client.IntegrationTests.csproj | Updated test framework from net8.0 to net10.0 |
| Source/EasyNetQ.Management.Client.ApprovalTests/EasyNetQ.Management.Client.ApprovalTests.csproj | Updated test framework from net8.0 to net10.0 |
| Source/EasyNetQ.Management.Client.slnx | Added new XML-based solution file format with project and folder structure |
| Source/EasyNetQ.Management.Client.sln | Removed legacy solution file format |
| .github/workflows/ci.yml | Updated .NET SDK to 10.x, changed all solution file references from .sln to .slnx, and updated framework matrix to net10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request upgrades the project to .NET 10 and updates related configuration, solution, and project files accordingly. It also replaces the legacy
.slnsolution file with a new.slnxformat and cleans up obsolete code related to JSON serialization for enums..NET 10 Upgrade and Project Configuration:
.csproj) to target .NET 10 (net10.0) instead of .NET 8 (net8.0), and removed .NET 6 support from the main library project. [1] [2] [3] [4].github/workflows/ci.yml) to use .NET SDK 10, update framework matrix, and reference the new.slnxsolution file throughout build and test steps. [1] [2] [3] [4] [5]Solution File Changes:
.slnsolution file and added a new.slnxsolution file with updated project and folder structure. [1] [2]Dependency and Code Cleanup:
System.Text.Jsonpackage reference in test projects to only apply tonet48targets, avoiding unnecessary references for .NET 10.JsonNumberEnumConverterimplementation