Conversation
paullinator
left a comment
There was a problem hiding this comment.
Needs to successfully pass blank tx files up to GUI
There was a problem hiding this comment.
This will probably work, but only "accidentally". This avoids doing an ls on the directory, but it doesn't actually disable loading the files themselves. That happens in loadTxFiles. Fortunately, without that initial ls, loadTxFiles just loops around uselessly and doesn't do anything. So, you've avoided most of the disk accesses, which means this would probably be OK for experimenting with.
To really be sure this works, I would go for the win and actually remove the call to loadTxFiles, which happens in $internalStreamTransactions. Then you know for sure we aren't loading any tx files from disk.
| // if (isNew) created.push(combinedTx) | ||
| // else if (files[txidHash] != null) changed.push(combinedTx) |
There was a problem hiding this comment.
You probably want to do changed.push(combinedTx) for every transaction, so the GUI still gets updates.
The idea here is to switch between onTxChanged / onNewTx, but since we don't have files, we just want everything to go in the "existing" bucket. The if (files[txidHash] != null) check was there to prevent crashes, but that's no longer needed thanks to your other changes.
71002b4 to
efff7ac
Compare
efff7ac to
b41b3cf
Compare
Review whether this satisifies the experiment requirements for the attached asana task