Add SideShift.ai exchange plugin#2204
Merged
peachbits merged 1 commit intoEdgeApp:developfrom Dec 23, 2020
Merged
Conversation
thehobbit85
approved these changes
Dec 14, 2020
Contributor
thehobbit85
left a comment
thehobbit85
left a comment
There was a problem hiding this comment.
Waiting for this PR to be fixed and merged before merging this:
EdgeApp/edge-exchange-plugins#100
Contributor
|
@paullinator, This is ready to be merged after the "develop" branch is out of "freeze" mode. |
Author
Is it still in freeze? @thehobbit85 @paullinator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds necessary metadata and logos for SideShift.ai functionality to Edge Wallet.
affiliateIdcan be obtained from the SideShift.ai affiliate page.PR Requirements
If you have made any visual changes to the GUI. Make sure you have:
The necessary JSON field is added to the
envfile, the plugin is initialized and the required SideShift.ai logos are added as described in the swap plugin integration Wiki page.Accompanying pull requests: