Make NoSolutionError pickleable#101
Open
tdsmith wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
Open
Make NoSolutionError pickleable#101tdsmith wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
tdsmith wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
Conversation
Sometimes you have an unsolveable optimization problem running in a subprocess. It's useful to allow NoSolutionError to be pickleable so that the exception can propagate back to the main process. Without this change, unpickling the exception fails. BaseException has an implementation of __reduce__, which defines the state to pickle, which remembers the args that its constructor received. Upon deserialization, the constructor of the exception is called with the arguments that the BaseException constructor received. If the BaseException constructor does not receive NoSolutionError's mandatory `problem` argument, we will try to call the NoSolutionError constructor without it, which will fail. An alternative is reimplementing __reduce__ on NoSolutionError.
Member
|
This sounds reasonable to me 👍 @veghp what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you have an unsolveable optimization problem running in a subprocess. It's useful to allow NoSolutionError to be pickleable so that the exception can propagate back to the main process.
Without this change, unpickling the exception fails. BaseException has an implementation of
__reduce__, which defines the state to pickle, which remembers the args that its constructor received. Upon deserialization, the constructor of the exception is called with the arguments that the BaseException constructor received.If the BaseException constructor does not receive NoSolutionError's mandatory
problemargument, we will try to call the NoSolutionError constructor without it, which will fail.An alternative is reimplementing
__reduce__on NoSolutionError.