UI update, code optimizations and minor improvements #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the code at the syntax level. Remove old-style namespace scopes. Fix modifiers. Force use 'var' instead of explicit type declarations. Remove empty lines and add additional lines where necessary.
Fix bottom name of the method. Also add additional info about method compilation.
Refactor DisassemblyPrettifier. Remove unused checks. Get rid of unnecessary ToList() conversions. And other optimizations.
… of the equality operator.
Refactor the code by improving naming, simplifying logic and optimization code. Rename constants and variables names. Change comments.
Fix a bug in IntrinsicsSourcesService where the data was not showing up when typing methods filter for the first time due to a misconception about how asynchronous code was used. Optimize IntrinsicsSourcesService by adding asynchronous fetching of content from github and compiling of all content instead of its parts separately.
After several hours of debugging, I got all parts of the code that allow to dynamically resolve styles from original Visual Studio components. Add MefExtensions because, without it, the MEF component services will not resolve. This solution should be no slower than the original. The styles update along with the theme rather than changing each color individually. This design avoids overengineering.
Redesign tool window, change the location and alignment of the elements. Refactor whole markup file. Small code refactoring. Remove IdeAppearanceProvider and MefExtensions.
No, I changed my mind. Switch from string.Empty to ""
…eak instructions and asm comments Also fix a bug related to incorrect coloring of non-asm content
… size label, move it to the header Could it break? - Yes, it will break! Do we care if it breaks? - Well, slightly... Did we forget about try-catch? - No! It is there. So everything is fine <3
Other non-readme-relared files are not updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire design has been updated.
More highlighting has been added to the disassembly code for control instructions, break instructions, and no-operation instructions.
It now looks like:
Other improvements: