Open
Conversation
…es and improve offset calculation
…DOs for nominal length and offset adjustments
…or layers to take the offset into account
…lygons with holes in Gmsh
…ting Sector and SectorInsulator geometries
…ons (using Point)
…nt for Sector and SectorInsulator
…t vertices manually
…length parameter TODO: it is using thickness to divide!
…ctor shaped conductor and insulator
…t on my feature branch too
… run CI on anything else
…perations - needed for sector shaped cable
…ons with debug logging
…sure polygon closure in sector geometry
…ulation and increase arc points for improved accuracy
…point definitions
…gn along with tests for CI
…ulator layer types
…ectorParams struct. just testing validation.
I followed the rules so the sectors play nice with other cable parts, In hope of being accepted into the main branch.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 52.08% 47.69% -4.39%
==========================================
Files 94 114 +20
Lines 6854 9013 +2159
==========================================
+ Hits 3570 4299 +729
- Misses 3284 4714 +1430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an added feature I added for the LineCableModels.jl to model the sector shaped cables commonly used in low voltage networks.
Geometry primitives adapted from: Urquhart, Andrew J., and Murray Thomson. 2014. “Cable Impedance Data”. Loughborough University. https://hdl.handle.net/2134/15544.