feat(pipe-tubular-FEM): add specialized function for creating Tubular cable parts#24
Open
MohamedNumair wants to merge 1 commit intoElecta-Git:mainfrom
Open
feat(pipe-tubular-FEM): add specialized function for creating Tubular cable parts#24MohamedNumair wants to merge 1 commit intoElecta-Git:mainfrom
MohamedNumair wants to merge 1 commit intoElecta-Git:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 52.08% 52.23% +0.15%
==========================================
Files 94 94
Lines 6854 6901 +47
==========================================
+ Hits 3570 3605 +35
- Misses 3284 3296 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added distinct geometry for tubular conductor for FEM geometry in case of being used as a pipe/sheath/armour.
Previously, the material inside the Tubular was overlapping with the existing conductors