Put reused filenames in constants#194
Draft
jayvdb wants to merge 2 commits intoElectron100:masterfrom
Draft
Conversation
jayvdb
commented
Feb 28, 2024
| /// Load a [Connection]. | ||
| pub fn establish_connection() -> Connection { | ||
| butane::db::connect(&ConnectionSpec::load(".butane/connection.json").unwrap()).unwrap() | ||
| let connspec = format!("{BUTANE_DIRNAME}/{CONNECTION_JSON_FILENAME}"); |
Collaborator
Author
There was a problem hiding this comment.
IMO the fact that the examples need to include these strings feels like a problem.
These shouldnt need to be so visible - they should be a hidden detail that are only important for unusual usage.
Collaborator
Author
There was a problem hiding this comment.
I think ConnectionSpec::load should auto detect if this filename exists
jayvdb
commented
Feb 28, 2024
| pub use sqlval::{AsPrimaryKey, FieldType, FromSql, PrimaryKeyType, SqlVal, SqlValRef, ToSql}; | ||
|
|
||
| /// Filenames used in butane. | ||
| pub mod _filenames { |
Collaborator
Author
There was a problem hiding this comment.
Using _ to indicate semi-private nature
jayvdb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.