Skip to content

Query completion attrs: query_type, rows_* #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YaroslavLitvinov merged 7 commits into from
Jan 8, 2026
Merged

Query completion attrs: query_type, rows_* #110

YaroslavLitvinov merged 7 commits into from
Jan 8, 2026

Conversation

@YaroslavLitvinov
Copy link
Contributor

@YaroslavLitvinov YaroslavLitvinov commented Jan 7, 2026 •
edited
Loading

query_type

For substantial amount of sqls, but not for all queries types

rows count

  • select - mapped into rows_produced
  • insert - mapped into rows_inserted
  • merge - mapped into rows_produced, rows_inserted
  • update - Missing
  • delete - Not supported
  • truncate - Missing

Related unitests added

@YaroslavLitvinov YaroslavLitvinov changed the title Query completion attrs: query_type, rows_count Query completion attrs: query_type, rows_* Jan 7, 2026
DanCodedThis
DanCodedThis approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@DanCodedThis DanCodedThis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaroslavLitvinov LGTM

@YaroslavLitvinov YaroslavLitvinov merged commit c4ffc58 into main Jan 8, 2026
3 checks passed
@YaroslavLitvinov YaroslavLitvinov deleted the yaro/query-completion-attrs2 branch January 8, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanCodedThis DanCodedThis DanCodedThis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaroslavLitvinov @DanCodedThis