Skip to content

Fixed bug related to investmentdata for hydro reservoirs and level parameter. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulStraus merged 3 commits into from
Nov 26, 2025
Merged

Fixed bug related to investmentdata for hydro reservoirs and level parameter. #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f2ada4
Fixed bug related to investmentdata for hydro reservoirs and level pa…
espenfb Nov 25, 2025
59cce62
Merge branch 'main' into bug/input_extension_level_parameter_hydro_re…
espenfb Nov 26, 2025
b0c09eb
Updated NEWS.md
espenfb Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release notes

## Unversioned

### Bugfixes

* Fix a bug in which field names for the capacities of a `Storage` node resulted in error message for the investment data checks.

## Version 0.9.3 (2025-10-23)

## Bugfixes
Expand Down
10 changes: 6 additions & 4 deletions ext/EMIExt/checks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,16 @@ function EMB.check_node_data(
return
end

for cap_fields ∈ fieldnames(typeof(data))
sub_data = getfield(data, cap_fields)
cap_map = Dict(:charge => charge, :level => level, :discharge => discharge)

for (cap, cap_fun) ∈ cap_map
sub_data = getfield(data, cap)
isnothing(sub_data) && continue
check_inv_data(
sub_data,
EMB.capacity(getproperty(n, cap_fields)),
EMB.capacity(cap_fun(n)),
𝒯,
" of field `" * String(cap_fields) * "`",
" of field `" * String(cap) * "`",
check_timeprofiles,
)
end
Expand Down