UniswapV4SwapHelpers contract #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnavascues
requested changes
Dec 23, 2025
Contributor
vnavascues
left a comment
vnavascues
left a comment
There was a problem hiding this comment.
Let me know if you agree with the suggestions (besides custom errors :D)
| }) | ||
| ); | ||
|
|
||
| if (zeroForOne) { |
Contributor
There was a problem hiding this comment.
If the if...else (or ?) is used to init param1 and param2, the duplicated code present in if (zeroForOne) {...} else {...} can be removed.
| UNIVERSAL_ROUTER.execute{ value: msg.value }(commands, inputs, deadline); | ||
|
|
||
| address tokenOut = Currency.unwrap(zeroForOne ? poolKey.currency1 : poolKey.currency0); | ||
| amountOut = IERC20(tokenOut).balanceOf(address(this)); |
Contributor
There was a problem hiding this comment.
Imho we need to do the balance diff here:
- tokenOutBalancePre
- Currency.unwrap
- tokenOutBalancePost
- amountOut = tokenOutBalancePost - tokenOutBalancePre
src/helpers/UniswapV4SwapHelpers.sol
Outdated
| } | ||
|
|
||
| function approveToken(address token, uint256 amount) private { | ||
| IERC20(token).approve(address(PERMIT2), amount); |
Contributor
There was a problem hiding this comment.
Better off using SafeERC20 & forceApprove (e.g., handle well USDT) around, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.