Add new ui and new installation #389

MoDarK-MK · 2025-10-16T13:42:32Z

MoDarK-MK · 2025-10-16T13:46:52Z

Hello
I hope you are well
This is my update for a better look and easier installation
If you like you can add it
Thank you

MoDarK-MK · 2025-10-16T13:47:36Z

Also in this case we have traceback

MoDarK-MK · 2025-10-16T13:49:47Z

if you like this tell me to code more

D3vil0p3r · 2025-10-17T17:37:53Z

@enty8080 can you give a look to this please? Also, the project needs to have at least requirements.txt file as in this PR or a pyproject.toml file instead of the setup.py.

MoDarK-MK · 2025-10-17T17:54:21Z

Hi, I hope you are well
I will look into it and send you the result
Thank you
I will send you all the updates for this tool

MoDarK-MK · 2025-10-17T21:10:59Z

Hello again
I did some things to make the tool better

D3vil0p3r · 2025-10-17T21:19:58Z

Hello again I did some things to make the tool better

Can you standardize it by using pyproject.toml approach instead of install.py?

enty8080 · 2025-10-18T00:14:37Z

@MoDarK-MK Why did you add install.py and uninstall.py when you can easily install Ghost with pip by providing URL to repository as an argument?

enty8080 · 2025-10-18T00:16:45Z

@MoDarK-MK Traceback encountered identifying attempt to inject custom printing methods instead of using badges:

(ghost)> ?
                                                                                              ERROR
  An error occurred: Console.print_empty() got an unexpected keyword argument 'end'!

Traceback (most recent call last):
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 545, in loop
    line = self.onecmd(line)
           ^^^^^^^^^^^^^^^^^
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 658, in onecmd
    getattr(self, 'do_' + args[0])(args)
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 431, in do_help
    self.print_empty(buffer, end='')
TypeError: Console.print_empty() got an unexpected keyword argument 'end'
(ghost)> exit
Traceback (most recent call last):
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 545, in loop
    line = self.onecmd(line)
           ^^^^^^^^^^^^^^^^^
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 658, in onecmd
    getattr(self, 'do_' + args[0])(args)
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/ghost/core/console.py", line 196, in do_exit
    raise EOFError
EOFError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/felix/Ghost/sas/Ghost/ghost/__init__.py", line 37, in <module>
    cli()
  File "/Users/felix/Ghost/sas/Ghost/ghost/__init__.py", line 35, in cli
    console.shell()
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/ghost/core/console.py", line 300, in shell
    self.loop()
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 549, in loop
    self.print_empty(end='')
TypeError: Console.print_empty() got an unexpected keyword argument 'end'

MoDarK-MK · 2025-10-18T00:17:09Z

Convenience for non-technical users
UI

@MoDarK-MK Why did you add install.py and uninstall.py when you can easily install Ghost with pip by providing URL to repository as an argument?

enty8080 · 2025-10-18T00:18:27Z

@MoDarK-MK To be honest, I think even non-technical users can read README.md with installation instructions (in current state it is single command)

MoDarK-MK · 2025-10-18T00:19:55Z

@MoDarK-MK Traceback encountered identifying attempt to inject custom printing methods instead of using badges:

(ghost)> ?
                                                                                              ERROR
  An error occurred: Console.print_empty() got an unexpected keyword argument 'end'!

Traceback (most recent call last):
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 545, in loop
    line = self.onecmd(line)
           ^^^^^^^^^^^^^^^^^
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 658, in onecmd
    getattr(self, 'do_' + args[0])(args)
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 431, in do_help
    self.print_empty(buffer, end='')
TypeError: Console.print_empty() got an unexpected keyword argument 'end'
(ghost)> exit
Traceback (most recent call last):
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 545, in loop
    line = self.onecmd(line)
           ^^^^^^^^^^^^^^^^^
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 658, in onecmd
    getattr(self, 'do_' + args[0])(args)
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/ghost/core/console.py", line 196, in do_exit
    raise EOFError
EOFError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/felix/Ghost/sas/Ghost/ghost/__init__.py", line 37, in <module>
    cli()
  File "/Users/felix/Ghost/sas/Ghost/ghost/__init__.py", line 35, in cli
    console.shell()
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/ghost/core/console.py", line 300, in shell
    self.loop()
  File "/Users/felix/miniforge3/lib/python3.12/site-packages/badges/cmd.py", line 549, in loop
    self.print_empty(end='')
TypeError: Console.print_empty() got an unexpected keyword argument 'end'

def print_empty(self, message: str = "", end: str = "\n") -> None:
    self.rich.print(message)

replace this code
console.py

MoDarK-MK · 2025-10-18T00:20:57Z

@MoDarK-MK To be honest, I think even non-technical users can read README.md with installation instructions (in current state it is single command)

if you dont like it we can remove it but try it

D3vil0p3r · 2025-10-18T00:21:51Z

ps: I am still testing

MoDarK-MK · 2025-10-18T00:22:49Z

MoDarK-MK · 2025-10-18T00:23:03Z

its working

MoDarK-MK · 2025-10-18T00:26:21Z

It's 4am in my country
If I die, I'll be back soon

D3vil0p3r · 2025-10-18T00:29:31Z

Omg I did finally. There is a missing main function that we need to add. So @MoDarK-MK please do the following things

MoDarK-MK · 2025-10-18T00:29:53Z

im here

D3vil0p3r · 2025-10-18T00:31:15Z

1- Remove the entire content from __init__.py BUT without deleting it.
2- Still inside ghost folder, create a file called __main__.py with the following content:

"""
MIT License

Copyright (c) 2020-2024 EntySec

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
"""

from ghost.core.console import Console

def cli() -> None:
    """ Ghost Framework command-line interface.

    :return None: None
    """

    console = Console()
    console.shell()

if __name__ == "__main__":
    cli()

MoDarK-MK · 2025-10-18T00:34:24Z

its ok now

D3vil0p3r · 2025-10-18T00:40:46Z

Just to explain the reason of this:

Before, if a main function is not present and CLI is defined in __init__.py, ghost.cli() is importable, ok, but it is potentially heavy and could have side effects.
By the main approach, python -m ghost works out of the box. Keeps imports clean: import ghost stays lightweight.

So, now, the update to pyproject.toml is complete. The last point depends on @enty8080 if he would like to keep its old style or the new style proposed by you @MoDarK-MK

MoDarK-MK · 2025-10-18T00:42:58Z

Thank you man
You helped me a lot tonight.

MoDarK-MK · 2025-10-18T00:43:22Z

Thank you both.

enty8080 · 2025-10-18T00:46:32Z

I'll review everything in the morning. Thank you again for your contribution!

D3vil0p3r · 2025-10-18T00:51:57Z

Thank you man You helped me a lot tonight.

There is a more robust and standardized approach that would be beneficial for the future. At this point :D @MoDarK-MK let's do that.

D3vil0p3r · 2025-10-18T01:00:37Z

On ghost folder, create a file cli.py with the following code:

from ghost.core.console import Console

def main() -> int:
    Console().shell()
    return 0

Then, edit __main__.py and it should have only this code:

from .cli import main

if __name__ == "__main__":
    raise SystemExit(main())

Then, edit __init__.py and it should have only this code:

"""
MIT License

Copyright (c) 2020-2024 EntySec

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
"""

__version__ = "…"

Finally, inside pyproject.toml, change ghost = "ghost.cli" to ghost = "ghost.cli:main".

Why this is more robust?

Because standard and robust for the future
Allow to run ghost on different manners:
- As a module: python -m ghost
- As a direct file: python ghost/__main__.py
- Importing programmatically: from ghost.cli import main; main()

D3vil0p3r · 2025-10-18T01:17:22Z

@MoDarK-MK it works. Just one thing about the interface:

Color codes are not expanded correctly (look at [1m[4m, [1m[0m or [1m).

Furthermore, uninstall.py is not needed. pip can easily be used to uninstall it. Keeping uninstall.py is just a waste for our eyes on the repo. Repo must be kept clean and simple.

@enty8080 regardless the decision of the interface, I suggest strongly to implement at least the changes done on ghost/cli.py, ghost/__init__.py and ghost/__main__.py, and on pyproject.toml and removing setup.py.

In case you will accept the new proposed interface, remember to add the rich dependency inside pyproject.toml.

MoDarK-MK · 2025-10-18T09:02:06Z

ok i try to solve it

D3vil0p3r · 2025-10-18T16:47:05Z

@enty8080 did you get a look this morning?

enty8080 · 2025-10-18T16:55:42Z

No, didn't have time

Modark added 4 commits October 16, 2025 09:31

Add new ui and new installation

6517048

Remove install.py comments

b56f121

Remove setup.py comments

9c67af9

Remove uninstall.py comments

03e016c

Modark added 13 commits October 16, 2025 14:51

Device With Rich Ui

ef892e8

Update activity.py and battery.py

d3d508d

Update download.py

a56e825

Update keyboard.py

d9ef41a

Update list.py

3c86bd5

Update network.py

a1613fa

Update openurl.py

7c797d8

Update press.py

b0fee59

Update screenshot.py

9ab7824

Update shell.py

df96442

Update sleep.py

0f90c5b

Update upload.py

75e5bae

Update wifi.py

d4c4230

D3vil0p3r mentioned this pull request Oct 17, 2025

GHOST FRAMEWORK BlackArch/blackarch#4484

Closed

Modark added 5 commits October 17, 2025 16:23

Auto-reconnect

72efbab

Add Device Analyzer & Real-Time Log Viewer

396df93

Add help command

e0f9a1e

Remove setup.py

573020a

Remove setup.py

7c0ac51

Remove requirements.txt & update pyproject.toml

32d2ebe

update console.py

d602f79

Add __main__.py

cb8b581

Modark added 2 commits October 17, 2025 21:06

last update

0802ca5

last update

566c371

update interfaace

fa39dbf

Uh oh!

Add new ui and new installation #389

Are you sure you want to change the base?

Add new ui and new installation #389

Uh oh!

Conversation

MoDarK-MK commented Oct 16, 2025

Uh oh!

MoDarK-MK commented Oct 16, 2025

Uh oh!

MoDarK-MK commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoDarK-MK commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

D3vil0p3r commented Oct 17, 2025

Uh oh!

MoDarK-MK commented Oct 17, 2025

Uh oh!

MoDarK-MK commented Oct 17, 2025

Uh oh!

D3vil0p3r commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enty8080 commented Oct 18, 2025

Uh oh!

enty8080 commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

enty8080 commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

enty8080 commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoDarK-MK commented Oct 18, 2025

Uh oh!

D3vil0p3r commented Oct 18, 2025

Uh oh!

enty8080 commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

MoDarK-MK commented Oct 16, 2025 •

edited

Loading

MoDarK-MK commented Oct 16, 2025 •

edited

Loading

D3vil0p3r commented Oct 17, 2025 •

edited

Loading

D3vil0p3r commented Oct 18, 2025 •

edited

Loading

D3vil0p3r commented Oct 18, 2025 •

edited

Loading