Identify characters in _OakSpeechText2B and `Printer_GetMonStats.ID…#1
Merged
Enzo-Matrix23 merged 25 commits intoEnzo-Matrix23:masterfrom Jan 21, 2026
Merged
Identify characters in _OakSpeechText2B and `Printer_GetMonStats.ID…#1Enzo-Matrix23 merged 25 commits intoEnzo-Matrix23:masterfrom
_OakSpeechText2B and `Printer_GetMonStats.ID…#1Enzo-Matrix23 merged 25 commits intoEnzo-Matrix23:masterfrom
Conversation
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc. - `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS` and `TILE_1BPP_SIZE` are used in some places. - Highlight an oversight in `OakSpeech` where several direct MBC bank switches are requested. - Remove redundant comments in home/overworld.asm. - Add unreferenced `FillBgMap` function to avoid a byte of dead code. - Some constants added in wram.asm. - Correctly separate the commented code in `SaveMainData`.
…name them to "toggleable objects" (#557)
… "hidden events" (#559)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That was an accident what was here before someone please help commit these changes or help me do it. (pret#144)