Address review feedback: remove emojis, enforce sentence case for headers by Copilot · Pull Request #29 · Eoic/ASCIIGround

Copilot · 2026-01-28T13:43:45Z

Addresses three review comments on the AI code style guide: emoji removal, emoji prohibition guidelines, and header capitalization standardization.

Changes

Removed emojis from code examples: Replaced // ❌ Bad and // ✅ Good with plain text // Bad and // Good
Added style enforcement sections:
- "Emojis and visual markers": Prohibits emojis (❌, ✅, 🚀, etc.) in code, comments, documentation, and commits. Use plain text labels instead.
- "Documentation style": Mandates sentence case for all titles and headers (capitalize first word only)
Converted all headers to sentence case: Updated 60+ section headers from Title Case to sentence case
- Example: "TypeScript Conventions" → "TypeScript conventions"
- Example: "Naming Conventions" → "Naming conventions"
Updated summary checklist: Added "No emojis" and "Use sentence case for titles" items

Before/After

<!-- Before -->
## TypeScript Conventions
### Type Declarations
// ❌ Bad - inline comments

<!-- After -->
## TypeScript conventions
### Type declarations  
// Bad - inline comments

Original prompt

Review the codebase. Based on the code style, create a code style guidelines that AI agents should use and follow.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Eoic · 2026-01-28T14:02:38Z

.github/AI_CODE_STYLE_GUIDE.md

+    return subtotal + tax;
+}
+
+// ✅ Good - self-documenting code with clear names


Do not use emojis anywhere in the code or the docs. Also add instructions in this file that emojis are not allowed anywhere at all.

Eoic · 2026-01-28T14:02:54Z

.github/AI_CODE_STYLE_GUIDE.md

+    return subtotal + tax;
+}
+
+// ✅ Good - complex logic with helpful comment


Remove emojis.

Eoic · 2026-01-28T14:04:11Z

.github/AI_CODE_STYLE_GUIDE.md

+
+---
+
+## Naming Conventions


Prefer using capitalization style that only capitalizes the first word in a title, for example, prefer using "Naming conventions" instead of "Naming Conventions". Add instructions about that and update this document to use the said style.

… sentence case Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Copilot

Pull request overview

Adds an AI-focused code style guide to the repo and links it from the main README, aiming to standardize formatting rules and documentation style (including emoji removal/prohibition and sentence-case headers).

Changes:

Add a new .github/AI_CODE_STYLE_GUIDE.md documenting repo-aligned TypeScript/ESLint conventions and documentation standards.
Add an AI-agent pointer link in README.md to the new style guide.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
README.md	Adds a link directing AI agents to the new style guide.
.github/AI_CODE_STYLE_GUIDE.md	Introduces a comprehensive AI code style guide, including emoji prohibition and sentence-case header rules.

Copilot · 2026-01-28T14:23:07Z

.github/AI_CODE_STYLE_GUIDE.md

+### Variables and Functions
+- Use **camelCase** for variables and functions: `animationSpeed`, `createRenderer`
+
+### Private members
+- Prefix private class members with underscore: `_state`, `_renderer`, `_permutations`


This heading uses Title Case ("Variables and Functions") even though the guide mandates sentence case for all headers. Rename it to sentence case (and scan nearby headings like "Getters and Setters" for the same issue).

Copilot · 2026-01-28T14:23:08Z

.github/AI_CODE_STYLE_GUIDE.md

+
+### Export patterns
+
+#### Grouped Exports


This subheading is still Title Case ("Grouped Exports"), which conflicts with the guide’s sentence-case rule for headers. Convert it (and the nearby "Direct Exports") to sentence case for consistency.

Suggested change

#### Grouped Exports

#### Grouped exports

Copilot · 2026-01-28T14:23:08Z

.github/AI_CODE_STYLE_GUIDE.md

+├── patterns/             # Pattern implementations
+│   ├── pattern.ts        # Base pattern class
+│   ├── perlin-noise-pattern.ts
+│   ├── rain-pattern.ts
+│   └── static-noise-pattern.ts
+├── rendering/            # Rendering implementations
+│   ├── ascii-renderer.ts
+│   └── renderer.ts
+├── utils/                # Utility functions
+│   └── seeded-random.ts
+├── plugins/              # Build plugins
+└── __tests__/            # Test files


The documented src/ directory tree doesn’t match the repo (e.g., src/demo/ exists). Update this tree snippet so it reflects the actual src/ structure.

Suggested change

├── patterns/ # Pattern implementations

│ ├── pattern.ts # Base pattern class

│ ├── perlin-noise-pattern.ts

│ ├── rain-pattern.ts

│ └── static-noise-pattern.ts

├── rendering/ # Rendering implementations

│ ├── ascii-renderer.ts

│ └── renderer.ts

├── utils/ # Utility functions

│ └── seeded-random.ts

├── plugins/ # Build plugins

└── __tests__/ # Test files

├── demo/ # Demo site source (templates, entrypoints)

├── patterns/ # Pattern implementations

│ ├── pattern.ts # Base pattern class

│ ├── perlin-noise-pattern.ts

│ ├── rain-pattern.ts

│ ├── static-noise-pattern.ts

│ └── dummy-pattern.ts

├── rendering/ # Rendering implementations

│ ├── ascii-renderer.ts

│ └── renderer.ts

├── utils/ # Utility functions

│ └── seeded-random.ts

├── plugins/ # Build plugins

│ └── eta-plugin.ts

└── __tests__/ # Test files

├── test-setup.ts

Copilot · 2026-01-28T14:23:09Z

.github/AI_CODE_STYLE_GUIDE.md

+     * Update pattern state based on context.
+     * @param context - The current pattern context.
+     */
+    public abstract update(context: PatternContext): this;


This abstract Pattern example uses update(...): this, but the actual base class in the repo defines update(...): Pattern (src/patterns/pattern.ts). Align this example signature with the real public API to avoid confusing contributors implementing new patterns.

Suggested change

public abstract update(context: PatternContext): this;

public abstract update(context: PatternContext): Pattern;

Copilot · 2026-01-28T14:23:09Z

.github/AI_CODE_STYLE_GUIDE.md

+
+### Emojis and visual markers
+- **Never use emojis** in code, comments, documentation, or commit messages
+- Do not use visual markers like ❌, ✅, 🚀, etc.


The "Emojis and visual markers" section prohibits emojis in documentation, but it currently includes emoji examples (❌/✅/🚀). This contradicts the rule and also violates the stated prohibition. Replace the emoji characters with plain-text descriptions (e.g., "x-mark", "checkmark") or remove the examples entirely.

Suggested change

- Do not use visual markers like ❌, ✅, 🚀, etc.

- Do not use visual markers like "x-mark", "checkmark", "rocket" icons, etc.

Copilot · 2026-01-28T14:23:09Z

.github/AI_CODE_STYLE_GUIDE.md

@@ -0,0 +1,911 @@
+# AI Code Style Guidelines for ASCIIGround


The document title is not in sentence case (it uses Title Case), but the guide mandates sentence case for all titles/headers. Update this top-level heading to sentence case to match the standard.

Suggested change

# AI Code Style Guidelines for ASCIIGround

# AI code style guidelines for ASCIIGround

Initial plan

35fd6c4

Copilot AI assigned Copilot and Eoic Jan 28, 2026

Copilot started work on behalf of Eoic January 28, 2026 13:44 View session

Copilot AI and others added 2 commits January 28, 2026 13:46

docs: add comprehensive AI code style guidelines

32c4de9

Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

docs: add reference to AI code style guide in README

48e37c9

Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Establish code style guidelines for AI agents~~ Add comprehensive AI code style guidelines Jan 28, 2026

Copilot AI requested a review from Eoic January 28, 2026 13:52

Copilot finished work on behalf of Eoic January 28, 2026 13:52

Copilot started work on behalf of Eoic January 28, 2026 13:54 View session

docs: move AI style guide to .github directory

61f081b

Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Copilot AI changed the title ~~Add comprehensive AI code style guidelines~~ Move AI style guide to .github directory Jan 28, 2026

Copilot finished work on behalf of Eoic January 28, 2026 13:56

Copilot started work on behalf of Eoic January 28, 2026 13:58 View session

docs: add inline comment guidelines to style guide

fee19c4

Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Copilot AI changed the title ~~Move AI style guide to .github directory~~ Add comprehensive AI code style guide with inline comment guidelines Jan 28, 2026

Copilot finished work on behalf of Eoic January 28, 2026 14:01

Eoic reviewed Jan 28, 2026

View reviewed changes

Copilot started work on behalf of Eoic January 28, 2026 14:06 View session

docs: address PR review comments - remove emojis, add guidelines, use…

59e7958

… sentence case Co-authored-by: Eoic <18404082+Eoic@users.noreply.github.com>

Copilot AI changed the title ~~Add comprehensive AI code style guide with inline comment guidelines~~ Address review feedback: remove emojis, enforce sentence case for headers Jan 28, 2026

Copilot AI requested a review from Eoic January 28, 2026 14:12

Copilot finished work on behalf of Eoic January 28, 2026 14:12

Eoic approved these changes Jan 28, 2026

View reviewed changes

Eoic marked this pull request as ready for review January 28, 2026 14:14

Copilot AI review requested due to automatic review settings January 28, 2026 14:14

Eoic merged commit dd1f746 into master Jan 28, 2026
11 checks passed

Copilot started reviewing on behalf of Eoic January 28, 2026 14:15 View session

Eoic deleted the copilot/create-code-style-guidelines branch January 28, 2026 14:15

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Address review feedback: remove emojis, enforce sentence case for headers#29

Address review feedback: remove emojis, enforce sentence case for headers#29
Eoic merged 6 commits intomasterfrom
copilot/create-code-style-guidelines

Copilot AI commented Jan 28, 2026 •

edited

Loading

Uh oh!

Eoic Jan 28, 2026

Uh oh!

Eoic Jan 28, 2026

Uh oh!

Eoic Jan 28, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	public abstract update(context: PatternContext): this;
	public abstract update(context: PatternContext): Pattern;

	- Do not use visual markers like ❌, ✅, 🚀, etc.
	- Do not use visual markers like "x-mark", "checkmark", "rocket" icons, etc.

	# AI Code Style Guidelines for ASCIIGround
	# AI code style guidelines for ASCIIGround

Uh oh!

Conversation

Copilot AI commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Before/After

Uh oh!

Eoic Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Eoic Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Eoic Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 28, 2026 •

edited

Loading