Chore/dev experience improvements#115
Draft
ConsciousEnergy wants to merge 4 commits intoEpisk-pos:mainfrom
Draft
Chore/dev experience improvements#115ConsciousEnergy wants to merge 4 commits intoEpisk-pos:mainfrom
ConsciousEnergy wants to merge 4 commits intoEpisk-pos:mainfrom
Conversation
added 4 commits
December 14, 2025 11:13
- Add cross-platform database download script (Node.js, Windows compatible) - Add file write error handler to download script - Ignore SpecStory test artifacts in .gitignore - Re-enable Network visualization E2E test Files: - scripts/download-db.js (new) - package.json - .gitignore - e2e/tests/cascade-visualizations.spec.ts
- Replace generic 'svg.first()' selector with container-specific selector - Prevents false positives from icon SVGs that appear earlier in DOM - Uses '.rounded-lg.border.relative.overflow-hidden' container to locate Network diagram
- Fix Windows file deletion issue: wait for 'close' event before unlinkSync() - Fix premature promise resolution: wait for 'close' event before resolving - Ensures file descriptor is fully closed and data flushed to disk - Prevents issues with subsequent file operations (e.g. readFileSync) - Applies fix to all error handlers and success handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes several developer experience improvements and bug fixes.
Changes:
Bug Fixes:
Testing:
Files Changed:
scripts/download-db.js(new) - Cross-platform download scriptpackage.json- Updated download script command.gitignore- Added SpecStory ignore patternse2e/tests/cascade-visualizations.spec.ts- Re-enabled Network test with specific selector