Skip to content

Conversation

@jbelien
Copy link
Member

@jbelien jbelien commented Oct 5, 2025

  • Upgrade PHPStan to 2.1.30
  • Fix PHPStan warnings

@jbelien jbelien self-assigned this Oct 5, 2025
@jbelien jbelien changed the title Bump PHPStan to 2.x 🚨 Bump PHPStan to 2.x Oct 5, 2025
@jbelien jbelien requested a review from Copilot October 5, 2025 12:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades PHPStan from version 0.12 to 2.1, which is a major version bump that requires fixing compatibility issues. The upgrade includes updating PHPStan configuration settings and resolving deprecated ignore patterns throughout the codebase.

  • Updates PHPStan dependency from ^0.12.83 to ^2.1 and strict rules from ^0.12.9 to ^2.0
  • Modernizes PHPStan configuration by changing level from "max" to 8 and updating ignore patterns
  • Updates all PHPStan ignore comments to use the new identifier-based syntax instead of generic @phpstan-ignore-line

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
composer.json Updates PHPStan and PHPStan strict rules to version 2.x
phpstan.neon Modernizes configuration with level 8 and new ignore patterns
Wikidata/Wikidata.php Updates PHPStan ignore comments to use specific identifiers
Command/WikidataCommand.php Updates PHPStan ignore comments to use specific identifiers
Command/GeoJSONCommand.php Updates PHPStan ignore comments and comments out unused method
Command/AbstractCommand.php Adds missing return statement to satisfy PHPStan

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jbelien jbelien merged commit 274a64c into master Oct 5, 2025
4 checks passed
@jbelien jbelien deleted the phpstan2 branch October 5, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants