Skip to content

fix(WikidataCommand): Always process P138 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tacsipacsi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(WikidataCommand): Always process P138 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 41 additions & 46 deletions Command/WikidataCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ function ($element): bool {

// Download Wikidata item
$path = sprintf('%s/%s.json', $outputDir, $identifier);
if (!file_exists($path)) {
self::save($identifier, $element, $path, $warnings);
}
self::save($identifier, $element, $path, $warnings);
}
}

Expand All @@ -132,27 +130,22 @@ function ($element): bool {

// Download Wikidata item
$path = sprintf('%s/%s.json', $outputDir, $wikidataTag);
if (!file_exists($path)) {
self::save($wikidataTag, $element, $path, $warnings);

$wikiPath = sprintf('%s/%s.json', $outputDir, $wikidataTag);
$entity = Wikidata::read($wikiPath);

$identifiers = Wikidata::extractNamedAfter($entity);
if (!is_null($identifiers)) {
foreach ($identifiers as $identifier) {
// Check that the value of the tag is a valid Wikidata item identifier
if (preg_match('/^Q[0-9]+$/', $identifier) !== 1) {
$warnings[] = sprintf('Format of `P138` (NamedAfter) property is invalid (%s) for in item "%s".', $identifier, $wikidataTag);
continue;
}

// Download Wikidata item
$path = sprintf('%s/%s.json', $outputDir, $identifier);
if (!file_exists($path)) {
self::save($identifier, $element, $path, $warnings);
}
self::save($wikidataTag, $element, $path, $warnings);

$entity = Wikidata::read($path);

$identifiers = Wikidata::extractNamedAfter($entity);
if (!is_null($identifiers)) {
foreach ($identifiers as $identifier) {
// Check that the value of the tag is a valid Wikidata item identifier
if (preg_match('/^Q[0-9]+$/', $identifier) !== 1) {
$warnings[] = sprintf('Format of `P138` (NamedAfter) property is invalid (%s) for in item "%s".', $identifier, $wikidataTag);
continue;
}

// Download Wikidata item
$path = sprintf('%s/%s.json', $outputDir, $identifier);
self::save($identifier, $element, $path, $warnings);
}
}
}
Expand Down Expand Up @@ -187,31 +180,33 @@ function ($element): bool {
*/
private static function save(string $identifier, $element, string $path, array &$warnings = []): void
{
$url = sprintf('%s%s.json', self::URL, $identifier);

try {
$client = new \GuzzleHttp\Client();
$client->request('GET', $url, [
'headers' => [
'User-Agent' => 'EqualStreetNames (https://equalstreetnames.org)',
'Accept' => 'application/json',
],
'sink' => $path,
]);
} catch (BadResponseException $exception) {
if (file_exists($path)) {
unlink($path);
}
if (!file_exists($path)) {
$url = sprintf('%s%s.json', self::URL, $identifier);

try {
$client = new \GuzzleHttp\Client();
$client->request('GET', $url, [
'headers' => [
'User-Agent' => 'EqualStreetNames (https://equalstreetnames.org)',
'Accept' => 'application/json',
],
'sink' => $path,
]);
} catch (BadResponseException $exception) {
if (file_exists($path)) {
unlink($path);
}

switch ($exception->getResponse()->getStatusCode()) {
case 404:
$warnings[] = sprintf('<warning>Wikidata item %s for %s(%d) does not exist.</warning>', $identifier, $element->type, $element->id);
break;
default:
$warnings[] = sprintf('<warning>Error while fetching Wikidata item %s for %s(%d): %s.</warning>', $identifier, $element->type, $element->id, $exception->getMessage());
break;
switch ($exception->getResponse()->getStatusCode()) {
case 404:
$warnings[] = sprintf('<warning>Wikidata item %s for %s(%d) does not exist.</warning>', $identifier, $element->type, $element->id);
break;
default:
$warnings[] = sprintf('<warning>Error while fetching Wikidata item %s for %s(%d): %s.</warning>', $identifier, $element->type, $element->id, $exception->getMessage());
break;
}
print_r($warnings);
}
print_r($warnings);
}
}
}
Loading