Add recurse-submodules option#25
Merged
ErickKramer merged 5 commits intoErickKramer:mainfrom Mar 28, 2025
Merged
Conversation
Owner
|
Thanks for the contribution, would you mind rebasing your branch onto main to address the merge conflicts? |
6ab7960 to
3e740cc
Compare
Contributor
Author
|
I’ve rebased the branch onto main. |
Owner
|
Thanks for that. I checked the changes, and since you are modifying the GitClone function, it would makes sense to have a test where the submodule update functionality is validated. Could you take care of that? |
Contributor
Author
|
I added some test cases. |
Owner
|
Thanks for addressing the tests. I checked and it worked out fine 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the
recurse-submodulesoption to automatically set up submodules when cloning.I tested this behavior using the following
.reposfile.rv import -i test.repos /tmp/example -r -swith shallow option
rv import -i test.repos /tmp/example -r -s -l