Simplify state-io. #720
Merged
Simplify state-io. #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a key-value interface and remove the TIMEBOOST_STAMP environment variable. The `timeboost` executable passes in the name of the stamp file.
akonring
approved these changes
Jan 14, 2026
|
|
||
| let is_recover = { | ||
| let stamp = format!("{sign_pubkey}.stamp"); | ||
| let mut io = StateIo::create().await.context("state i/o")?; |
Contributor
There was a problem hiding this comment.
Thought: stamp could maybe be input to StateIo::create.
Contributor
Author
There was a problem hiding this comment.
I wanted to keep state-io generic in the sense that consumers could load and store arbitrary key-value pairs, not necessarily just the stamp value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a key-value interface and removes the TIMEBOOST_STAMP environment variable. The
timeboostexecutable passes in the name of the stamp file.