URenderPipeline: Fix blend state with default/mc shaders on 1.17-1.206, properly #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….6, properly The previous workaround for this (5f02456) had incorrectly assumed that all our code running after it would only touch the global GL state but not MC's GlBlendState global state, however `BlendState.activate` (and `UGraphics.Global.blendState`, which forwards to that) does actually set MC's GlBlendState global state as well, rendering the workaround largely ineffective. This commit fixes that by adding an internal method to `BlendState` which bypasses MC's `GlBlendState`, and then using that method from the workaround in `URenderPipeline` as well as `ManagedGlState`.
Sychic
approved these changes
Dec 1, 2025
Johni0702
deleted the
feature/em-3509-all-essential-menus-appear-blank-on-1171-1206
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous workaround for this (5f02456) had incorrectly assumed that all our code running after it would only touch the global GL state but not MC's GlBlendState global state, however
BlendState.activate(andUGraphics.Global.blendState, which forwards to that) does actually set MC's GlBlendState global state as well, rendering the workaround largely ineffective.This commit fixes that by adding an internal method to
BlendStatewhich bypasses MC'sGlBlendState, and then using that method from the workaround inURenderPipelineas well asManagedGlState.