-
Notifications
You must be signed in to change notification settings - Fork 0
Remove legacy llama.cpp inference code #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a9fd60f
Remove legacy llama.cpp inference code
joeldrotleff f78bf82
docs: update AGENTS.md for llama.cpp removal and deep research deploy…
joeldrotleff 1d220f3
Add deep research and SGLang fields to config template
joeldrotleff 19b2e14
Merge branch 'main' into joel/cleanup-dead-code
joeldrotleff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefaultEnableDeepResearch = truewill be impossible to override tofalsevia config file due tomergeConfigslogic.The
isZeroValuehelper (line 246) treatsfalseas the zero value for booleans. WhenLoadOrDefaultmerges an existing config with defaults, anyenable_deep_research: falseset by the user will be detected as "zero" and silently replaced with the defaulttrue. This means users cannot disable deep research once it's enabled by default.The same issue affects
SGLang.TrustRemoteCode(defaulttrue) andSGLang.DisableRadixCache(defaulttrue).Possible fixes:
*bool(pointer) for toggles so thatnilrepresents "not set" vs explicitfalse.Option 1: Always prefer existing bool values in merge
// mergeStructFields recursively merges struct fields func mergeStructFields(existing, defaults, result reflect.Value) { for i := 0; i < existing.NumField(); i++ { existingField := existing.Field(i) defaultField := defaults.Field(i) resultField := result.Field(i) if !resultField.CanSet() { continue } // For nested structs, merge fields recursively if existingField.Kind() == reflect.Struct { mergeStructFields(existingField, defaultField, resultField) continue } + // Bools have no distinguishable "unset" zero value; + // always keep whatever the existing config says. + if existingField.Kind() == reflect.Bool { + resultField.Set(existingField) + continue + } + if isZeroValue(existingField) { resultField.Set(defaultField) } else { resultField.Set(existingField) } } }Note: Option 1 means a brand-new config file (all bools at Go zero =
false) would not pick uptruedefaults, so you'd need to ensureNewDefaultConfigis used for fresh installs rather than going through the merge path. The existing code already does this (line 185), but verify the full flow.