Skip to content

Comments

Set config as global, update cache, refactor, add core#119

Draft
kchojn wants to merge 3 commits intoEthTx:masterfrom
kchojn:cache_fix
Draft

Set config as global, update cache, refactor, add core#119
kchojn wants to merge 3 commits intoEthTx:masterfrom
kchojn:cache_fix

Conversation

@kchojn
Copy link
Contributor

@kchojn kchojn commented Feb 23, 2022

  • bump web3 version
  • add core module
  • move EthTxConfig to core and use BaseSettings
  • Refactor ethtx.py
  • lru_cahce size from config

@kchojn kchojn marked this pull request as ready for review February 23, 2022 14:07
@piotr-rudnik
Copy link

So, global object for settings is not a good idea, but there is little we can do without changing more time, so it's ok. But I'm not sure about changing to pydantic settings model now, it's just by multiple people and everyone would need to upgrade their code to make it work with this. My proposition is to separate my pydantic settings model to another pull request, and merge it with another major version bump.

@kchojn kchojn marked this pull request as draft March 1, 2022 11:15
@kchojn
Copy link
Contributor Author

kchojn commented Mar 1, 2022

You are right, major changes, will do it in 0.4.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants