Set config as global, update cache, refactor, add core#119
Draft
kchojn wants to merge 3 commits intoEthTx:masterfrom
Draft
Set config as global, update cache, refactor, add core#119kchojn wants to merge 3 commits intoEthTx:masterfrom
kchojn wants to merge 3 commits intoEthTx:masterfrom
Conversation
|
So, global object for settings is not a good idea, but there is little we can do without changing more time, so it's ok. But I'm not sure about changing to pydantic settings model now, it's just by multiple people and everyone would need to upgrade their code to make it work with this. My proposition is to separate my pydantic settings model to another pull request, and merge it with another major version bump. |
Contributor
Author
|
You are right, major changes, will do it in 0.4.0 version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web3versioncoremoduleEthTxConfigto core and use BaseSettingsethtx.pylru_cahcesize from config