feat: add cache sync timeout configuration #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable cache synchronization timeout to address the "Informer fails to sync, timeout waiting for API" error. The change introduces a new command-line flag that allows users to specify how long the controller should wait for caches to sync during startup.
- Adds a new
--cache-sync-timeoutflag with a default value of 2 minutes - Configures the controller manager to use this timeout value
- Imports the necessary
configpackage from controller-runtime
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fahedouch
force-pushed
the
cache_sync_timeout
branch
2 times, most recently
from
3d841e3 to
45e1cf4
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
cache_sync_timeout
branch
from
fa8f286 to
336391d
Compare
fahedouch
commented
Dec 30, 2025
| echo "No pod found for provider ${PACKAGE_NAME}" | ||
| fi | ||
| exit 1 | ||
| fi |
Author
There was a problem hiding this comment.
it was only for debugging purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added a configurable cache synchronization timeout to avoid error :
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested