Skip to content

Conversation

@volodeyka
Copy link
Collaborator

No description provided.

@volodeyka volodeyka requested a review from eupp April 1, 2021 09:12
eventstructure.v Outdated

Definition sca_suffix : E -> seq E := suffix (fica_lt).

Definition contr_loc f : E -> seq E :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does contr stands for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contraction

eventstructure.v Outdated
Definition sca_suffix : E -> seq E := suffix (fica_lt).

Definition contr_loc f : E -> seq E :=
fun e => (f ∘ (same_loc (lab e) \o lab)ᶠ) e.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks a bit cryptic. For example, there are two o notations, both of them denote some kind of composition, but different ))
Also ^f notation is non-standard and a bit misleading.
Finally, you can apply eta conversion here: (fun x => f x) == f

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't apply eta conversion because we use e inside of (same_loc (lab e) \o lab)ᶠ)

relations.v Outdated
Variables (f g : T -> seq T) (p : pred T).

Definition composition :=
fun x => do y <- g x; f y.
Copy link
Collaborator

@eupp eupp Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Kleisli composition. You can use notation (>=>) if you will import monae.

relations.v Outdated

End Operations.

Notation "p 'ᶠ'" := (fun_of_pred p) (at level 10).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we were discussing that this is related to "tests" from Kleene Algebras with Tests, but currently we cannot use the notation from relation-algebra. So until I will fix the blocking problem in relation-algebra let's either:

  1. do not use any notation for this;
  2. use the same notation as in relation-algebra, so later we'll be able to migrate smoothly.

I prefer the second solution.

@volodeyka
Copy link
Collaborator Author

should we close this PR for now?

@eupp
Copy link
Collaborator

eupp commented May 25, 2021

should we close this PR for now?

Let it be here for a while. We'll return to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants