-
-
Notifications
You must be signed in to change notification settings - Fork 30
Align serialize with hydrator picking up nested DTOs when #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WyriHaximus
wants to merge
1
commit into
EventSaucePHP:main
Choose a base branch
from
WyriHaximus-labs:align-serialize-with-hydrator-picking-up-nested-DTOs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Align serialize with hydrator picking up nested DTOs when #93
WyriHaximus
wants to merge
1
commit into
EventSaucePHP:main
from
WyriHaximus-labs:align-serialize-with-hydrator-picking-up-nested-DTOs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a project I have a DTO that I want to pass around:
```php
<?php
declare(strict_types=1);
namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full;
use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;
final readonly class Worldmap
{
/** @param array<Tile> $tiles */
public function __construct(
public string $type,
public string $version,
public string $worldmap,
public array $tiles,
) {
}
}
```
If has a property that is a list of the following DTO:
```php
<?php
declare(strict_types=1);
namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap;
use EventSauce\ObjectHydrator\MapFrom;
use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet;
final readonly class Tile
{
public function __construct(
#[MapFrom('fileName')]
public string $fileName,
#[MapFrom('offSet')]
public OffSet $offSet,
) {
}
}
```
And that DTO has one final sub DTO as a property:
```php
<?php
declare(strict_types=1);
namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;
final readonly class OffSet implements Work
{
public function __construct(
public int $x,
public int $y,
) {
}
}
```
Then I generate the Hydrator object with the follwing code:
```php
$hydratorGenerator = new ObjectMapperCodeGenerator();
$code = $hydratorGenerator->dump([\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap::class], Hydrator::class);
file_put_contents($rootPath . '/src/Generated/Hydrator.php', $code);
```
That generates the following code, the `hydrateObject` method has both the `Tile` and `OffSet` but the `serializeObjectOfType` method is lacking them:
```php
<?php
declare(strict_types=1);
use EventSauce\ObjectHydrator\IterableList;
use EventSauce\ObjectHydrator\ObjectMapper;
use EventSauce\ObjectHydrator\UnableToHydrateObject;
use EventSauce\ObjectHydrator\UnableToSerializeObject;
use Generator;
class Hydrator implements ObjectMapper
{
private array $hydrationStack = [];
public function __construct() {}
/**
* @template T of object
* @param class-string<T> $className
* @return T
*/
public function hydrateObject(string $className, array $payload): object
{
return match($className) {
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap($payload),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile($payload),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($payload),
default => throw UnableToHydrateObject::noHydrationDefined($className, $this->hydrationStack),
};
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap
{
$properties = [];
$missingFields = [];
try {
$value = $payload['type'] ?? null;
if ($value === null) {
$missingFields[] = 'type';
goto after_type;
}
$properties['type'] = $value;
after_type:
$value = $payload['version'] ?? null;
if ($value === null) {
$missingFields[] = 'version';
goto after_version;
}
$properties['version'] = $value;
after_version:
$value = $payload['worldmap'] ?? null;
if ($value === null) {
$missingFields[] = 'worldmap';
goto after_worldmap;
}
$properties['worldmap'] = $value;
after_worldmap:
$value = $payload['tiles'] ?? null;
if ($value === null) {
$missingFields[] = 'tiles';
goto after_tiles;
}
if (is_array($value[array_key_first($value)] ?? false)) {
try {
$this->hydrationStack[] = 'tiles';
$value = $this->hydrateObjects('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $value)->toArray();
} finally {
array_pop($this->hydrationStack);
}
}
$properties['tiles'] = $value;
after_tiles:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap', $exception, stack: $this->hydrationStack);
}
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile
{
$properties = [];
$missingFields = [];
try {
$value = $payload['fileName'] ?? null;
if ($value === null) {
$missingFields[] = 'fileName';
goto after_fileName;
}
$properties['fileName'] = $value;
after_fileName:
$value = $payload['offSet'] ?? null;
if ($value === null) {
$missingFields[] = 'offSet';
goto after_offSet;
}
if (is_array($value)) {
try {
$this->hydrationStack[] = 'offSet';
$value = $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($value);
} finally {
array_pop($this->hydrationStack);
}
}
$properties['offSet'] = $value;
after_offSet:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $exception, stack: $this->hydrationStack);
}
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet
{
$properties = [];
$missingFields = [];
try {
$value = $payload['x'] ?? null;
if ($value === null) {
$missingFields[] = 'x';
goto after_x;
}
$properties['x'] = $value;
after_x:
$value = $payload['y'] ?? null;
if ($value === null) {
$missingFields[] = 'y';
goto after_y;
}
$properties['y'] = $value;
after_y:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet', $exception, stack: $this->hydrationStack);
}
}
private function serializeViaTypeMap(string $accessor, object $object, array $payloadToTypeMap): array
{
foreach ($payloadToTypeMap as $payloadType => [$valueType, $method]) {
if (is_a($object, $valueType)) {
return [$accessor => $payloadType] + $this->{$method}($object);
}
}
throw new \LogicException('No type mapped for object of class: ' . get_class($object));
}
public function serializeObject(object $object): mixed
{
return $this->serializeObjectOfType($object, get_class($object));
}
/**
* @template T
*
* @param T $object
* @param class-string<T> $className
*/
public function serializeObjectOfType(object $object, string $className): mixed
{
try {
return match($className) {
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap' => $this->serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap($object),
default => throw new \LogicException("No serialization defined for $className"),
};
} catch (\Throwable $exception) {
throw UnableToSerializeObject::dueToError($className, $exception);
}
}
private function serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap(mixed $object): mixed
{
\assert($object instanceof \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap);
$result = [];
$type = $object->type;
after_type: $result['type'] = $type;
$version = $object->version;
after_version: $result['version'] = $version;
$worldmap = $object->worldmap;
after_worldmap: $result['worldmap'] = $worldmap;
$tiles = $object->tiles;
static $tilesSerializer0;
if ($tilesSerializer0 === null) {
$tilesSerializer0 = new \EventSauce\ObjectHydrator\PropertySerializers\SerializeArrayItems(...array (
));
}
$tiles = $tilesSerializer0->serialize($tiles, $this);
after_tiles: $result['tiles'] = $tiles;
return $result;
}
/**
* @template T
*
* @param class-string<T> $className
* @param iterable<array> $payloads;
*
* @return IterableList<T>
*
* @throws UnableToHydrateObject
*/
public function hydrateObjects(string $className, iterable $payloads): IterableList
{
return new IterableList($this->doHydrateObjects($className, $payloads));
}
private function doHydrateObjects(string $className, iterable $payloads): Generator
{
foreach ($payloads as $index => $payload) {
yield $index => $this->hydrateObject($className, $payload);
}
}
/**
* @template T
*
* @param class-string<T> $className
* @param iterable<array> $payloads;
*
* @return IterableList<T>
*
* @throws UnableToSerializeObject
*/
public function serializeObjects(iterable $payloads): IterableList
{
return new IterableList($this->doSerializeObjects($payloads));
}
private function doSerializeObjects(iterable $objects): Generator
{
foreach ($objects as $index => $object) {
yield $index => $this->serializeObject($object);
}
}
}
```
When I pass `Tile` and `OffSet` to the list of to be generated Hydrators like this:
```php
$hydratorGenerator = new ObjectMapperCodeGenerator();
$code = $hydratorGenerator->dump([
\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap::class,
\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile::class,
\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet::class,
], Hydrator::class);
file_put_contents($rootPath . '/src/Generated/Hydrator.php', $code);
```
I'm getting the expected object mapper class:
```php
<?php
declare(strict_types=1);
use EventSauce\ObjectHydrator\IterableList;
use EventSauce\ObjectHydrator\ObjectMapper;
use EventSauce\ObjectHydrator\UnableToHydrateObject;
use EventSauce\ObjectHydrator\UnableToSerializeObject;
use Generator;
class Hydrator implements ObjectMapper
{
private array $hydrationStack = [];
public function __construct() {}
/**
* @template T of object
* @param class-string<T> $className
* @return T
*/
public function hydrateObject(string $className, array $payload): object
{
return match($className) {
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile($payload),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($payload),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap' => $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap($payload),
default => throw UnableToHydrateObject::noHydrationDefined($className, $this->hydrationStack),
};
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile
{
$properties = [];
$missingFields = [];
try {
$value = $payload['fileName'] ?? null;
if ($value === null) {
$missingFields[] = 'fileName';
goto after_fileName;
}
$properties['fileName'] = $value;
after_fileName:
$value = $payload['offSet'] ?? null;
if ($value === null) {
$missingFields[] = 'offSet';
goto after_offSet;
}
if (is_array($value)) {
try {
$this->hydrationStack[] = 'offSet';
$value = $this->hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($value);
} finally {
array_pop($this->hydrationStack);
}
}
$properties['offSet'] = $value;
after_offSet:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $exception, stack: $this->hydrationStack);
}
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet
{
$properties = [];
$missingFields = [];
try {
$value = $payload['x'] ?? null;
if ($value === null) {
$missingFields[] = 'x';
goto after_x;
}
$properties['x'] = $value;
after_x:
$value = $payload['y'] ?? null;
if ($value === null) {
$missingFields[] = 'y';
goto after_y;
}
$properties['y'] = $value;
after_y:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet', $exception, stack: $this->hydrationStack);
}
}
private function hydrateWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap(array $payload): \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap
{
$properties = [];
$missingFields = [];
try {
$value = $payload['type'] ?? null;
if ($value === null) {
$missingFields[] = 'type';
goto after_type;
}
$properties['type'] = $value;
after_type:
$value = $payload['version'] ?? null;
if ($value === null) {
$missingFields[] = 'version';
goto after_version;
}
$properties['version'] = $value;
after_version:
$value = $payload['worldmap'] ?? null;
if ($value === null) {
$missingFields[] = 'worldmap';
goto after_worldmap;
}
$properties['worldmap'] = $value;
after_worldmap:
$value = $payload['tiles'] ?? null;
if ($value === null) {
$missingFields[] = 'tiles';
goto after_tiles;
}
if (is_array($value[array_key_first($value)] ?? false)) {
try {
$this->hydrationStack[] = 'tiles';
$value = $this->hydrateObjects('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile', $value)->toArray();
} finally {
array_pop($this->hydrationStack);
}
}
$properties['tiles'] = $value;
after_tiles:
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap', $exception, stack: $this->hydrationStack);
}
if (count($missingFields) > 0) {
throw UnableToHydrateObject::dueToMissingFields(\WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap::class, $missingFields, stack: $this->hydrationStack);
}
try {
return new \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap(...$properties);
} catch (\Throwable $exception) {
throw UnableToHydrateObject::dueToError('WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap', $exception, stack: $this->hydrationStack);
}
}
private function serializeViaTypeMap(string $accessor, object $object, array $payloadToTypeMap): array
{
foreach ($payloadToTypeMap as $payloadType => [$valueType, $method]) {
if (is_a($object, $valueType)) {
return [$accessor => $payloadType] + $this->{$method}($object);
}
}
throw new \LogicException('No type mapped for object of class: ' . get_class($object));
}
public function serializeObject(object $object): mixed
{
return $this->serializeObjectOfType($object, get_class($object));
}
/**
* @template T
*
* @param T $object
* @param class-string<T> $className
*/
public function serializeObjectOfType(object $object, string $className): mixed
{
try {
return match($className) {
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile' => $this->serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile($object),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet' => $this->serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($object),
'WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap' => $this->serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap($object),
default => throw new \LogicException("No serialization defined for $className"),
};
} catch (\Throwable $exception) {
throw UnableToSerializeObject::dueToError($className, $exception);
}
}
private function serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile(mixed $object): mixed
{
\assert($object instanceof \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile);
$result = [];
$fileName = $object->fileName;
after_fileName: $result['fileName'] = $fileName;
$offSet = $object->offSet;
$offSet = $this->serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet($offSet);
after_offSet: $result['offSet'] = $offSet;
return $result;
}
private function serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap⚡️Tile⚡️OffSet(mixed $object): mixed
{
\assert($object instanceof \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile\OffSet);
$result = [];
$x = $object->x;
after_x: $result['x'] = $x;
$y = $object->y;
after_y: $result['y'] = $y;
return $result;
}
private function serializeObjectWyriHaximus⚡️Apps⚡️WorldOfWarcraft⚡️DataMiner⚡️Images⚡️Worldmap⚡️Full⚡️Worldmap(mixed $object): mixed
{
\assert($object instanceof \WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap);
$result = [];
$type = $object->type;
after_type: $result['type'] = $type;
$version = $object->version;
after_version: $result['version'] = $version;
$worldmap = $object->worldmap;
after_worldmap: $result['worldmap'] = $worldmap;
$tiles = $object->tiles;
static $tilesSerializer0;
if ($tilesSerializer0 === null) {
$tilesSerializer0 = new \EventSauce\ObjectHydrator\PropertySerializers\SerializeArrayItems(...array (
));
}
$tiles = $tilesSerializer0->serialize($tiles, $this);
after_tiles: $result['tiles'] = $tiles;
return $result;
}
/**
* @template T
*
* @param class-string<T> $className
* @param iterable<array> $payloads;
*
* @return IterableList<T>
*
* @throws UnableToHydrateObject
*/
public function hydrateObjects(string $className, iterable $payloads): IterableList
{
return new IterableList($this->doHydrateObjects($className, $payloads));
}
private function doHydrateObjects(string $className, iterable $payloads): Generator
{
foreach ($payloads as $index => $payload) {
yield $index => $this->hydrateObject($className, $payload);
}
}
/**
* @template T
*
* @param class-string<T> $className
* @param iterable<array> $payloads;
*
* @return IterableList<T>
*
* @throws UnableToSerializeObject
*/
public function serializeObjects(iterable $payloads): IterableList
{
return new IterableList($this->doSerializeObjects($payloads));
}
private function doSerializeObjects(iterable $objects): Generator
{
foreach ($objects as $index => $object) {
yield $index => $this->serializeObject($object);
}
}
}
```
This change set ensures those nested DTOs are also picked up for the serializer as with the hydrator.
The following code was used to quickly proof the new code would work before creating tests:
```php
<?php declare(strict_types=1);
require_once __DIR__ . '/vendor/autoload.php';
final class ChildObject
{
public function __construct(
public readonly string $value,
) {}
}
final class ParentObject
{
/**
* @param ChildObject[] $list
*/
public function __construct(
public readonly array $list,
) {}
}
$mapper = new \EventSauce\ObjectHydrator\ObjectMapperUsingReflection();
$object = $mapper->hydrateObject(ParentObject::class, [
'list' => [
['value' => 'one'],
['value' => 'two'],
],
]);
var_export($object);
var_export($mapper->serializeObject($object));
$dumper = new \EventSauce\ObjectHydrator\ObjectMapperCodeGenerator();
$classesToDump = [ParentObject::class];
$code = $dumper->dump($classesToDump, 'Yolo');
echo $code;
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I have a DTO that I want to pass around:
If has a property that is a list of the following DTO:
And that DTO has one final sub DTO as a property:
Then I generate the Hydrator object with the follwing code:
That generates the following code, the
hydrateObjectmethod has both theTileandOffSetbut theserializeObjectOfTypemethod is lacking them:When I pass
TileandOffSetto the list of to be generated Hydrators like this:I'm getting the expected object mapper class:
This change set ensures those nested DTOs are also picked up for the serializer as with the hydrator.
The following code was used to quickly proof the new code would work before creating tests: