Pressure sensing on Windows: Refactor of https://github.com/Evidlo/remarkable_mouse/pull/90#97
Open
NicoM1 wants to merge 1 commit intoEvidlo:masterfrom
Open
Pressure sensing on Windows: Refactor of https://github.com/Evidlo/remarkable_mouse/pull/90#97NicoM1 wants to merge 1 commit intoEvidlo:masterfrom
NicoM1 wants to merge 1 commit intoEvidlo:masterfrom
Conversation
…lso add platform detection so that --pressure supports windows or linux
Author
|
Note that this coincidentally seems to fix #79 so maybe it should just be the default mode on Windows. |
Owner
|
Thanks for the contribution! There are some minor changes to the architecture on the master branch that changed recently. |
kingkro123
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm hoping for easy access to pressure-sensitivity on Windows, so I spent a little bit of time refactoring #90
Thanks to @aklevans for doing all the real work in that PR.
Changes:
Note that I'm much more of a C++ programmer than a python one, so I tried to generally follow the style in this repo but there may still be refactors desired to fit in better. Happy to do small things so this can be merged into main though.
Important: