fix: New-TablePercentageBar - rendering with conditional formatting in v1.14.0+ #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Codex is King :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #516 a regression was identified where New-TablePercentageBar with conditional formatting rendered as a string and/or produced invalid JS.
Changes:
New-TablePercentageBarInternal.ps1:
Use ConvertTo-Json -Compress for conditional formatting so the render call doesn’t span multiple lines.
New-HTMLTable.ps1:
Replace the percentBar unquoting logic with a regex replacement that:
unquotes the render call
unescapes JSON quotes (")
converts \u0027 to ' so the JS parses correctly.
Result:
percentBar(...) render function is emitted as valid JS and the bars render again.
Not going to pretend that Codex didn't hunt this down and suggest the fix. I tested it myself in a few large dashboards and it seems to fix the issue with no ill side affects.