Skip to content

DEV LookupMapping made some getters public #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hail-cookies wants to merge 10 commits into
base: 1.x-dev
Choose a base branch
from
Open

DEV LookupMapping made some getters public #558

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
da3ef47
Merge branch '1.x-dev' of https://github.com/ExFace/Core into InputMa…
hail-cookies Apr 1, 2025
350cd38
REF LookupMapping
hail-cookies Apr 1, 2025
e4e6627
DEV LookupMapping first draft
hail-cookies Apr 1, 2025
476e10b
FIX LookupMapping removed unnecessary using
hail-cookies Apr 1, 2025
6c5da8b
DEV LookupMapping cleanup
hail-cookies Apr 1, 2025
3bca14d
Merge branch '1.x-dev' of https://github.com/ExFace/Core into InputMa…
hail-cookies Apr 1, 2025
bc23e0e
REF LookupMapping
hail-cookies Apr 1, 2025
fabf629
REF LookupMapping
hail-cookies Apr 2, 2025
87d4476
Merge branch '1.x-dev' of https://github.com/ExFace/Core into DataShe…
hail-cookies Sep 17, 2025
f1e8b0a
DEV LookupMapping made some getters public
hail-cookies Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CommonLogic/DataSheets/Mappings/LookupMapping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ protected function setLookupColumn($string) : LookupMapping
* {@inheritDoc}
* @see \exface\Core\Interfaces\DataSheets\LookupMappingInterface::getToExpression()
*/
protected function getToExpression() : ExpressionInterface
public function getToExpression() : ExpressionInterface
{
return $this->toExpression;
}
Expand Down Expand Up @@ -579,7 +579,7 @@ protected function setMatches(UxonObject $uxon) : LookupMapping
* Returns an array of matches - each providing pairs of expressions in the from-sheet and in the lookup-sheet
* @return void
*/
protected function getMatches() : array
public function getMatches() : array
{
if ($this->matchesUxon === null) {
return [];
Expand Down