Skip to content

Feature/input code widget fix #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergejriel wants to merge 2 commits into
base: 1.x-dev
Choose a base branch
from
Open

Feature/input code widget fix #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
579926a
Fix: multiple error windows tabs fix.
sergejriel Dec 9, 2025
4eccfdc
Merge remote-tracking branch 'fork/1.x-dev' into feature/InputCode-wi…
sergejriel Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CommonLogic/DataQueries/SqlDataQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ public function createDebugWidget(DebugMessage $debug_widget)

$inputCode_widget = WidgetFactory::createFromUxonInParent($sql_tab, new UxonObject([
'widget_type' => 'InputCode',
'id' => $debug_widget->getId() . '_SqlDataQuery_InputCode',
'width' => '100%',
'height' => '100%',
"language" => 'sql',
Expand Down
1 change: 1 addition & 0 deletions CommonLogic/DataSheets/DataSheet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3395,6 +3395,7 @@ public function createDebugWidget(DebugMessage $debug_widget, string $tabCaption
$debugSheet = $this->createDebugSheet();
$uxon_widget = WidgetFactory::createFromUxonInParent($uxon_tab, new UxonObject([
'widget_type' => 'InputUxon',
'id' => $debug_widget->getId() . '_DataSheet_InputUxon',
'caption' => PhpClassDataType::findClassNameWithoutNamespace(get_class($this)),
'hide_caption' => true,
'width' => '100%',
Expand Down
6 changes: 6 additions & 0 deletions Exceptions/ExceptionTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ public function createWidget(UiPageInterface $page)
public function createDebugWidget(DebugMessage $debug_widget)
{
$page = $debug_widget->getPage();

// Appends the exception ID only once for preventing IDs like: DebugMessage_ID_ID_ID...
if (!str_contains($debug_widget->getId(), $this->getId())) {
$debug_widget->setId($debug_widget->getId() . '_' . $this->getId());
}
$translator = $debug_widget->getWorkbench()->getCoreApp()->getTranslator();
// Add a tab with a user-friendly error description
if ($debug_widget->findChildById('error_tab') === false) {
Expand Down Expand Up @@ -204,6 +209,7 @@ public function createDebugWidget(DebugMessage $debug_widget)
$context_tab->setCaption($translator->translate('ERROR.CONTEXT_CAPTION'));
$context_tab->addWidget(WidgetFactory::createFromUxonInParent($context_tab, new UxonObject([
'widget_type' => 'InputUxon',
"id" => $debug_widget->getId() . '_' . $context_tab->getId() . '_InputUxon',
'disabled' => true,
'width' => '100%',
'height' => '100%',
Expand Down
2 changes: 1 addition & 1 deletion Widgets/Parts/CodeFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function getDialect() : ?string
* Sets the dialect for formatted language. Example: language: "sql" and dialect: "tsql".
*
* @uxon-property dialect
* @uxon-type [sql,tsql mariadb,mysql,plsql,postgresql]
* @uxon-type [sql,tsql,mariadb,mysql,plsql,postgresql]
*
* @param string $dialect
* @return $this
Expand Down