feat: added MinPlayers property #660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you explain why on earth we would need this 😭 |
louis1706
requested changes
Oct 22, 2025
Someone-193
requested changes
Oct 25, 2025
| foreach (CustomRole role in CustomRole.Registered) | ||
| { | ||
| if (role.Role == ev.Player.Role.Type && !role.IgnoreSpawnSystem && role.SpawnChance > 0 && !role.Check(ev.Player) && (role.SpawnProperties is null || role.SpawnedPlayers < role.SpawnProperties.Limit)) | ||
| if (role.Role == ev.Player.Role.Type && !role.IgnoreSpawnSystem && role.SpawnChance > 0 && !role.Check(ev.Player) && (role.SpawnProperties is null || role.SpawnedPlayers < role.SpawnProperties.Limit) && (role.MinPlayers is 0 || Server.PlayerCount == role.MinPlayers)) |
Collaborator
There was a problem hiding this comment.
Shouldn't this be >= in player count comparison ?
Collaborator
There was a problem hiding this comment.
Should NPC's be included in this check btw? Server.PlayerCount includes dummies, but Server.ConnectedPlayerCount will ignore them
Collaborator
There was a problem hiding this comment.
I'm still waiting on this lol
obvEve
approved these changes
Dec 24, 2025
|
You are actually counting NPC twice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
added MinPlayers property and check to CustomRole.cs
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Not compiled nor tested but it should work.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other