Skip to content

[Bungee] Fix duplicate handlers #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lolka13372 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bungee] Fix duplicate handlers #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...-bungeecord/src/main/java/dev/simplix/protocolize/bungee/netty/NettyPipelineInjector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@ public void injectBefore(Connection connection, String baseName, String name, Ch
Preconditions.checkNotNull(channelHandler, "The channelHandler cannot be null!");
try {
final Object channelWrapper = ReflectionUtil.getChannelWrapper(connection);
if (channelWrapper != null)
((Channel) ReflectionUtil.channelWrapperChannelField.get(channelWrapper)).pipeline().addBefore(baseName, name, channelHandler);
if (channelWrapper != null) {
ChannelPipeline pipeline = ((Channel) ReflectionUtil.channelWrapperChannelField.get(channelWrapper)).pipeline();
if (pipeline.get(name) != null) {
pipeline.remove(name);
}
pipeline.addBefore(baseName, name, channelHandler);
}
} catch (final Exception e) {
ProxyServer.getInstance().getLogger().log(Level.SEVERE, "Exception occurred while injecting into netty pipeline", e);
}
Expand All @@ -32,8 +37,13 @@ public void injectAfter(Connection connection, String baseName, String name, Cha
Preconditions.checkNotNull(channelHandler, "The channelHandler cannot be null!");
try {
final Object channelWrapper = ReflectionUtil.getChannelWrapper(connection);
if (channelWrapper != null)
((Channel) ReflectionUtil.channelWrapperChannelField.get(channelWrapper)).pipeline().addAfter(baseName, name, channelHandler);
if (channelWrapper != null) {
ChannelPipeline pipeline = ((Channel) ReflectionUtil.channelWrapperChannelField.get(channelWrapper)).pipeline();
if (pipeline.get(name) != null) {
pipeline.remove(name);
}
pipeline.addAfter(baseName, name, channelHandler);
}
} catch (final Exception e) {
ProxyServer.getInstance().getLogger().log(Level.SEVERE, "Exception occurred while injecting into netty pipeline", e);
}
Expand Down