New Checkmarks on WebGUI#395
Conversation
Modified WebGUI page with checkmarks to give users the option to "Keep configuration file" when uninstalling, and to "Bypass postponed days" when doing a F/W update check.
Fine-tuning.
I really like the fact that the checkbox is cleared after a check for new firmware completes, whether an update is available or not. |
|
@Martinski4GitHub Hi Martinski! It looks absolutely fantastic. Km happy with this design choice you made below the buttons instead of beside them! Sorry I haven't had the time to test this yet, similar to you my work has really picked up. My goal will be to test the new check boxes as soon as possible though! (Specifically the skip postpone checkbox!) will just fake an update available and see what it does! |
Yeah, no worries; I understand. Take your time. As you said: "We can't be late if we have no ETA." :>)
Sounds good. Have a good night, bud!! |
|
I did find a bug while testing on my Gnuton node, I tested after the uninstall and so the settings file was TBD as found below:
And the WebUI was giving me an undefined error for TBD value as found below:
|
|
I should mention, outside of that bug, everything went well with the uninstall test before hand, and all other related testing. Sorry for the delay BTW; I've been so swamped with work, and then my girlfriend threw me at a technical issue, and you know how it is, if it impacts the girlfriend it's top priority! Can't leave that stuff hanging ;) Hope you've been doing good buddy! Hope you managed to get that new router setup finally! |
|
Oh! And to mention, and I also did the test flash on my Gnuton router also! So second router to do a flash from the WebUI without any issues 😉 I did get a failure email, seems that the comparison is still including the Gnuton prefix somehow. (I was sure we fixed this already?) But the flash itself went well lol!
|
Very good catch!! It's great that you're doing testing on other platforms as well to catch the "little things." |
Buddy, we don't put out garbage! We put out gold, we think of as much as we can before we let the the people out in the wild have a wack at it 😉 |
Great to hear!!! Whooo Hooo!!! LOL!! :>)
I absolutely know what you mean (been there, done that :>). You've got your priorities right, bud!!
I have not set up the new router as the main network router yet; I have it acting as a wired AP in our master bedroom, and it's been working great so far. I was planning to make the switch this weekend but other things came up, and then I started doing the implementation for the cron schedule input on the WebGUI and got "in the zone" coding for a couple of hours yesterday and today. I'm now about 95% done. Here's a little taste:
|
If she says something needs fixing, it needs fixing!
WOW! LOOKS BEAUTIFUL! YOUVE GONE WILD! |
Oh man, that "prefix issue" is still popping up unexpectedly!!! I think that part of the code needs some rewrites to make it more robust. |
I keep calling it prefix... SUFFIX! Hehehe |
Exactly!! That's how I view things as well. We do as much testing & validation as we can "in-house" (given our spare time) to make sure all the "nuts, bolts, screws, and rivets are tight & secure" and "ready to go" before the official launch. |
As much time as it takes, we aren't in a rush here. I feel I've mostly only done review since the initial PoC (trust me I'm not complaining) someone has to do the code review and validation, just happy I can still be apart of your process buddy! Watching you go is always a learning experience |
I would have to review the code very closely to see what the best course of action would be. It's been a while since I last reviewed it. |
The "undefined" error has now been fixed with the latest commit in PR #396. |
Thank you @Martinski4GitHub ! I'll be checking it out shortly! |
FYI, other code changes were made to address "Warnings" from the latest Linter tool report. |
17 warnings? Out of thousands of lines of code? It's gotta be clean in that case! Thank you for "Linting" our code throughout the process! I like knowing it's not just functional, but also follows proper standards. There's a difference between it 'working" and proper standards, sometimes a fairly large difference between them. I can get something working, doesn't mean it's proper, you've been major help for that! |
3 participants
Modified WebGUI page with checkmarks to give users the option to "Keep configuration file" when uninstalling, and to "Bypass postponed days" when doing a F/W update check.
The default value for each checkmark is always false/disabled so users must choose to enable them every time they want to perform the desired action.