Merge pull #1 and #3, use modified #2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use pull #2 and adjust the total player count on logout - Lock down the console commands via bukkit permissions
I am unable to test this at the moment, but unless I somehow missed a mistake, this should work.
[Needs testing] Fix to show the actual player cap
…einfo (alias gqi) displays information about who's in the queue.
…, also tried to make the code threadSafe.
Merge DynCap
maven build script
use bukkit repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the spirit of pull #2 does fix the bug. I've changed the code more to accommodate it. Also locks down the console commands with bukkit permissions (in addition to the existing Player object check).
As this merges pulls #1, #2, and #3, those can be closed as only this needs to be accepted. Thanks guys!