Skip to content

Conversation

@Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Dec 29, 2025

Description of the proposed changes

The projectiles of the Exodus's Oblivion Cannon only had a StrategicIconSize of 2, while the Omen's Oblivion Cannons had one of 3, even though the Omen's actually deal less damage. Increasing the StrategicIconSize of the Exodus' Oblivion Cannon to 3 fixes this inconsistency and also better reflects the weapon's high alpha damage.

Checklist

Summary by CodeRabbit

  • Style

    • Increased the strategic icon size for the Oblivion Cannon projectile (from 2 to 3) to improve its visibility on the strategic interface.
  • Documentation

    • Added a changelog entry noting the strategic icon size update to reflect the weapon's visual alignment with its power.

✏️ Tip: You can customize this high-level summary in your review settings.

@Basilisk3 Basilisk3 requested review from BlackYps and lL1l1 December 29, 2025 00:11
@Basilisk3 Basilisk3 added the feature: strategic icons related to strategic icons label Dec 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Walkthrough

Increases the projectile Display.StrategicIconSize for the Oblivion Cannon from 2 to 3; no other fields or behavior were changed.

Changes

Cohort / File(s) Summary
Strategic Icon Display
projectiles/ADFOblivionCannon01/ADFOblivionCannon01_proj.bp, changelog/snippets/graphics.6993.md
Display.StrategicIconSize changed from 2 to 3 in the Oblivion Cannon projectile; added changelog snippet documenting the change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • BlackYps

Poem

I am a rabbit with a keen eye,
The cannon's icon hops up high,
From two to three it springs in sight,
A small tweak brightening the fight,
Hooray — a clearer map tonight 🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the proposed changes, includes rationale, documents changelog compliance, and confirms reviewer request. However, testing done section is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and accurately describes the primary change: increasing the StrategicIconSize of the Exodus's Oblivion Cannon from 2 to 3, matching the changeset exactly.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Basilisk3 Basilisk3 changed the title Increase the StrategicIconSize of the Exodus' Oblivion Cannon to 3 Increase the StrategicIconSize of the Exodus's Oblivion Cannon to 3 Dec 31, 2025
@Basilisk3 Basilisk3 merged commit 8434c72 into FAForever:develop Dec 31, 2025
6 checks passed
@Basilisk3 Basilisk3 deleted the Exodus_projectile_icon branch December 31, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: strategic icons related to strategic icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants