[Feat] 구독한 전략 페이지 구현 #153
Merged
[Feat] 구독한 전략 페이지 구현 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
🚀 Storybook이 배포 됐어요! 확인하러 가기 => https://6729e72ee61d8f57ca4790fb-lszycaekwe.chromatic.com/ |
kimpra2989
temporarily deployed
to
feat/favorites-page-151 - FinalProject_team3_FE PR #153
Render
Destroyed
ssumanlife
approved these changes
Nov 29, 2024
Contributor
ssumanlife
left a comment
ssumanlife
left a comment
There was a problem hiding this comment.
고생하셨습니다 !🥲
전략상세 쪽은 그대로인데 배포에러가 없네용... 다행... 배포에러는 없으니 일단 승인!!
| basePath: PATH.STRATEGIES, | ||
| pageSize: COUNT_PER_PAGE, | ||
| }) | ||
| const { data } = useGetStrategiesData({ isReady, page, size: COUNT_PER_PAGE }) |
Contributor
There was a problem hiding this comment.
이것도 다시보니 size도 searchParams로 구하는게 좋겠네요,,,,
kimpra2989
temporarily deployed
to
feat/favorites-page-151 - FinalProject_team3_FE PR #153
Render
Destroyed
|
🚀 Storybook이 배포 됐어요! 확인하러 가기 => https://6729e72ee61d8f57ca4790fb-gmdszeqvmx.chromatic.com/ |
|
🚀 Storybook이 배포 됐어요! 확인하러 가기 => https://6729e72ee61d8f57ca4790fb-fdlnquncyz.chromatic.com/ |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
🔍 작업 내용
구독한 전략 페이지 작업했습니다!
기존에 수민님이 작성해주신 StrategiesModel이 api 수정 이슈로 변경되어서 함꼐 수정했습니다
로그인만 msw를 사용하도록 설정되어 있는데 스웨거 api가 아직 완성되지 않은 상태라 mockdata로 작업했습니다
🔧 변경 사항
📸 스크린샷 (권장)
🙏 리뷰 참고 (선택 사항)
📄 기타 (선택 사항)