feat: replace os.system with subprocess.run and add npm install check #381
Conversation
✅ Deploy Preview for fosscprogresstracker canceled.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you 🙏🏻 for contributing to progress-tracker by @FOSS-Community. Looking Forward for more contributions.
script.py
Outdated
| # Check input file exists | ||
| # ------------------------------ | ||
| if not Path(FILE_NAME).is_file(): | ||
| print(f"Error: The input file does not exist: {FILE_NAME}", file=sys.stderr) |
There was a problem hiding this comment.
it's better to raise an exception here, instead of sys.exit
There was a problem hiding this comment.
okay sir, i will fix both sys.exit to raise an exception.
script.py
Outdated
| # Check if npx is installed | ||
| # ------------------------------ | ||
| if not shutil.which("npx"): | ||
| print("Error: 'npx' is not installed. Please install Node.js first: https://nodejs.org/", file=sys.stderr) |
There was a problem hiding this comment.
here also, use exception instead of sys.exit
Mr-Sunglasses
left a comment
Mr-Sunglasses
left a comment
There was a problem hiding this comment.
LGTM 🎊 , Thanks @ApurveKaranwal
Thank you so much, Sir! Contributing to FOSSC has been an amazing experience for me. I truly enjoyed working on this issue, learning along the way, and seeing my contribution get merged into the main branch. I’m really motivated to keep improving and contribute more in the future!🚀 |
2 participants
Fixes
Fixes #380
Description
Replaced all unsafe
os.system()calls withsubprocess.run()for safer command execution and proper error handling.Added a check so that
github-readme-to-htmlis installed only if it’s missing.Technical details
subprocess.run()withcheck=Trueto catch errorsnpxavailability before running commandsdist/folder if it doesn’t existTests
python script.py -i README.md -o output.html -t "My Project"dist/github-readme-to-htmlinstalls only if missingChecklist
Update index.md).mainormaster).visible errors.