Skip to content

Comments

Add-Date-filter-functionality#156

Open
Kirubapanneers wants to merge 7 commits intoFOSSUChennai:mainfrom
Kirubapanneers:add-location-date-search
Open

Add-Date-filter-functionality#156
Kirubapanneers wants to merge 7 commits intoFOSSUChennai:mainfrom
Kirubapanneers:add-location-date-search

Conversation

@Kirubapanneers
Copy link

Hi @nammahari,Thanks for your feedback on my previous PR. I have now implemented a filter functionality as you said instead of search, allowing users to refine events based on location and date. Could you review the changes and let me know if this aligns with the site scope before I create a new PR?
image

@JustinBenito
Copy link
Contributor

Hey @Kirubapanneers the layout looks really cool, with just minor tweeks I think we can get it to prod.
Can you please change the PR from a draft, so that once everything is done we can merge it asap

Cheers :)

@Kirubapanneers Kirubapanneers marked this pull request as ready for review March 11, 2025 16:09
@Kirubapanneers
Copy link
Author

Hey @JustinBenito , I'll make the minor tweaks and update the PR shortly. I've also marked the PR as ready for review. Let me know if there's anything else to refine.

@JustinBenito
Copy link
Contributor

Hey @Kirubapanneers are you working on it or is this the updated PR buddy

Cheers :)

@Kirubapanneers
Copy link
Author

Hiii,@JustinBenito, This is the updated PR . Let me know if any changes are needed.

@JustinBenito
Copy link
Contributor

Hey @Kirubapanneers just ran the code and I must admit, I see so much of work here. That is something really great.
But one thing I noticed, was that most of them seems to be redundant, like the sorting is something that we already do based on the date of the event and it works just fine. Coming to the sorting, we wont really store the previous months events and no community will also be adding communities into the far future. So the split of the current month and upcoming months also works just fine. If there is an important sorting that we would need to do, it would be of location.

I just designed this quick design, lmk your thoughts.
Reducing the space used by the filters would be a great addition, I feel.

Screenshot 2025-03-24 at 4 56 11 PM

Cheers :)

@Kirubapanneers
Copy link
Author

Hey @JustinBenito, I have now refined the filtering to focus only on location based filter as suggested. let me know if any further adjustments are needed!........
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants