feat(dark-mode): add dark mode feature#193
feat(dark-mode): add dark mode feature#193Kishan1835 wants to merge 2 commits intoFOSSUChennai:mainfrom
Conversation
|
Wow, this looks stellar @Kishan1835 🔥 One would be to change the github contribute button on top to text-white in dark mode. |
JustinBenito
left a comment
JustinBenito
left a comment
There was a problem hiding this comment.
Overall the new PR looks promising, but there are few gaps which would be really great if we could fill it.
Can you please look into the given suggestions @Kishan1835 and update with a new PR.
Cheers :)
P.S also can you please include a video showing all the new changes, so that it would be great to understand the new changes.
Thanks
src/components/EmptyEventCard.tsx
Outdated
| @@ -0,0 +1,17 @@ | |||
| import { CalendarX } from '@phosphor-icons/react'; | |||
|
|
|||
There was a problem hiding this comment.
This seems to be a copy of the no-events-card.tsx which already exists, can I please know why you introduced the same here @Kishan1835 ?
also was curious to know why an empty ClientThemeProvider has been added ?
| @@ -0,0 +1,26 @@ | |||
| import React, { useState } from 'react'; | |||
|
|
|||
| interface TooltipProps { | |||
There was a problem hiding this comment.
Also can I know why we are abstracting just this tooltips component into a separate file, I understand it helps readability but apart from that is there any specific requirement in doing this @Kishan1835 ?
tailwind.config.ts
Outdated
| darkMode: 'class', // Enable dark mode using the 'class' strategy | ||
| content: [ | ||
| './src/pages/**/*.{js,ts,jsx,tsx,mdx}', | ||
| './src/components/**/*.{js,ts,jsx,tsx,mdx}', |
There was a problem hiding this comment.
also just curious if there is a specific idea behind adding only few directories ?
|
@JustinBenito Thank you for the feedback! I’ll definitely look into the suggestions and make the necessary updates soon. Appreciate your time reviewing the PR! |
|
Hey @Kishan1835 any update on this PR? |
Sarveshmrao
added
question
|
@JustinBenito @Sarveshmrao |
|
Hey @Kishan1835 can you provide us a screenshot to look into or preferably a video. Cheers ::) |
3 participants
Dark Mode feature added to the whole Page